All Slimefun items that are represented as heads break when placed
Boomer-1 opened this issue · 11 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
When a server is in a version below 1.19.4, and a player logs in above 1.19.3, if they place any machine, regulator, capacitor, cargo node, any item that is represented with a head, while wearing a helmet, having only 1 of the item in their hand when placed will cause the item to turn into a cs-corelib head. Jeff believes the cause of this maybe, because it's a head and you have a helmet on the listener cancels and the blockplaceevent doesn't happen.
He mentioned this may be tied to the issue.
ViaVersion/ViaVersion@734bc9e
📑 Reproduction Steps
start server below 1.19.4
client logs in to server with 1.19.4 or higher
viaversion must be on the server
player must have a helmet on (enchants not needed)
player goes to place a slimefun item that is an actual head, holding only 1 of the item
when placed it turns into cs-corelib head.
💡 Expected Behavior
the item when placed to remain the item.
📷 Screenshots / Videos
No response
📜 Server Log
no errors
📂 /error-reports/ folder
none
💻 Server Software
Paper
🎮 Minecraft Version
1.19.x
⭐ Slimefun version
dev 1056
🧭 Other plugins
No response
I have been testing this so much, with so many different variables and IT WAS BECAUSE I WASN'T WEARING ARMOR!?
I could cry
I have been testing this so much, with so many different variables and IT WAS BECAUSE I WASN'T WEARING ARMOR!?
I could cry
I would have never expected this but apparently 1.19.4 added a function where you could swap armour pieces somehow.
Just tested it like Jeff requested, seems like that ViaVersion/ViaVersion@734bc9e toggle caused this.
By disabling armor-toggle-fix on ViaVersion's config.yml this bug doesn't occurred anymore.
Opened an issue on viaversion side, os hopefully they will fix this on their own. I don't know which issue disabling
armor-toggle-fixcan cause, if you know ?
honestly no clue, im not even sure what it even does when enabled.
Opened an issue on viaversion side, os hopefully they will fix this on their own.
I don't know which issue disabling armor-toggle-fix can cause, if you know ?
If you’re happy with that downside then we have had reports it fixes the issue for you, the only reason we’ve not openly recommended it yet is we’ve not found the time to know the effects of the toggle, but if you’re right it seems like an ok temporary sacrifice.
Opened an issue on viaversion side, os hopefully they will fix this on their own. I don't know which issue disabling
armor-toggle-fixcan cause, if you know ?honestly no clue, im not even sure what it even does when enabled.
Asked a friend who disabled the option, you can't just switch armor using right click, that's the only "drawbacks"
Yes if it doesn't create duplication, or other downside effect, it's very minor.
Very happy that you mentionned this issue, so I know the fix, and I know it's a real issue :D
Don’t ha, we took so long working out the cause. Due to it being only when wearing a helmet with a single item in the stack it meant the reports coming in were so varied and it looked like a transient issue. We really got lucky someone made the helmet connection which made it all fall into place.
ViaVersion have pushed an update which looks to have fixed this specific issue (ViaVersion/ViaVersion@4971eea). I will check later when I'm free but if anyone wants to confirm the fix before this, you'll need the most recent version of ViaVersion (Build 711, ViaVersion-4.7.1-SNAPSHOT.jar)