ExpCollector tick 19.49%
SrMonsterYT opened this issue · 17 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
cpu increase in slimefun version #79
spark lag: https://spark.lucko.me/8VyzUYO33o
slimefun and addons version: https://prnt.sc/fUoukhWGWEsI
timings slimefun: https://prnt.sc/t6NXi__V-13s
📑 Reproduction Steps
ExpCollector
💡 Expected Behavior
no 19%
📷 Screenshots / Videos
No response
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Other (please specify in your description)
🎮 Minecraft Version
1.20.x
⭐ Slimefun version
Slimefun DEV - 1079 (git 5b458f1)
🧭 Other plugins
No response
Checking the code reveals it uses code that will be changed in the inventory system rewrite.
It will be solved, but no ETAs or time estimate. See #3170
Checking the code reveals it uses code that will be changed in the inventory system rewrite.
sorry I didn't understand, so is it a problem that will be solved?
I'd recommend focusing on your entity/tick issues as the primary concern, 19% of this is bad but not terrible compared to ticking:
Obviously, this is still taking ages so we need to look into it but it's worth noting.
Now, 1079 was PR #3892 however, this did not touch ExpCollector or related code. Can you please confirm what build this actually happened on?
I'd recommend focusing on your entity/tick issues as the primary concern, 19% of this is bad but not terrible compared to ticking:
Obviously, this is still taking ages so we need to look into it but it's worth noting.
Now, 1079 was PR #3892 however, this did not touch ExpCollector or related code. Can you please confirm what build this actually happened on?
I'd recommend focusing on your entity/tick issues as the primary concern, 19% of this is bad but not terrible compared to ticking:
Obviously, this is still taking ages so we need to look into it but it's worth noting.
Now, 1079 was PR #3892 however, this did not touch ExpCollector or related code. Can you please confirm what build this actually happened on?
The PR you are linking is 7 years old
He means Dev 1079 I think which, as Walshy pointed out, should have any impact here, what so ever. Given we have had sight of Sr's timings reports a few times over the last few weeks, I'm fairy happy this is a new occurance in terms of his experience within his server, but not likely due to recent updates. I'll do some tests locally during my lunch to see if I can get the same result(s).
@SrMonsterYT Can you please try to find the exp collectors you have on the server and send a video of the setup?
I have managed to recreate this but only after pumping SO much EXP into the system, this report was spawning 10k worth of exp orbs per tick into 4 collectors with unlimited deep storage keeping 12k flasks over the duration of a small 60 second profile.
Short of disabling the blocks/removing them from the world, you'll need to await a resolution.
it's a simple farm the skeleton wither dies and the exp collector collects and is the only player who has it on the whole server, I asked other players of the 100 online and no one had only 1 player, the server has about 2 weeks only because I reset and increased his processor, so I think this is a slimefun bug, is there any way to increase this exp collector tick?
photo: https://prnt.sc/YR_qmuXScDmc
video: https://youtu.be/irmzlTM8AkE
100 player on: https://prnt.sc/Ng6wX1vOe1om
i have updated to another version also slimefun: https://prnt.sc/ueHdLKqz-1hC
new spark: https://spark.lucko.me/G7TOvpXW0a
it seems that the other version has corrected, but I ask you to leave it open I will confirm today in the evening in Brazil
It's not the version, nothing in this code has changed.
Your timings showed 2 exp collectors and the one you just showed seems very tame and is likely the reason for the lower usage. If you can find the 2nd one it's possible the setup there is more intense and would give you something to mitigate.
To be clear, this is on Slimefun, not yourself, but it's not something that can be resolved with ease so we need to give you the tools to self-regulate this.
It's not the version, nothing in this code has changed.
Your timings showed 2 exp collectors and the one you just showed seems very tame and is likely the reason for the lower usage. If you can find the 2nd one it's possible the setup there is more intense and would give you something to mitigate.
To be clear, this is on Slimefun, not yourself, but it's not something that can be resolved with ease so we need to give you the tools to self-regulate this.
now yes i hadn't done spark correctly it seems the problem still has and this happens only with 1 exp collector from 1 player
spark: https://spark.lucko.me/5zHrVkp9PI
I spent 5 minutes killing like I did in the video and turned on the spark
in version 1.19.4 I had about 20 - 30 players who had this exp collector farm and I never had this problem you yourself have seen my reports from the past it was only in the supreme, this is now strange to me even my tps is falling because of this
Hmm, ok this is great - thanks!
sorry to bother you again but here is the second exp collector from another player
photo: https://prnt.sc/rYYeGAXA-7Eo
is there anything I can do other than wait for it to be fixed?
Short of disabling the blocks/removing them from the world, you'll need to await a resolution.
ok i will wait for a correction, thank you very much
Short of disabling the blocks/removing them from the world, you'll need to await a resolution.
ok i will wait for a correction, thank you very much
sorry to comment here, but is version 83 the fix for this?