Opening Backpack and Slimefun Guide at the same time causes unwanted behavior
JustAHuman-xD opened this issue · 14 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
(See reproduction steps and expected behavior) This bug can lead to mis use of the backpack, dupe bugs, etc. I have confirmed that this exists at least and I have been told that you can dupe items by allowing another player to upgrade the dropped backpack while you have it open, and then you both take out items.
📑 Reproduction Steps
- Get a slimefun guide
- Get a backpack
- Place slimefun guide in off hand
- Place backpack in main hand
- Right Click to open inventory
- Observe broken behavior (try moving the backpack item, putting disallowed items in the bag, etc)
(Note it works with the slots reversed, backpack in offhand guide in main)
Observe that you can drop the backpack, put anything in the backpack, etc.
💡 Expected Behavior
I expect either the backpack to not open or if it does open to be properly recognized as a back pack and have all the correct handlers.
📷 Screenshots / Videos
No response
📜 Server Log
https://paste.gg/p/anonymous/70c3e68a275b46ed922e5be3693a3dc6
📂 /error-reports/ folder
(N/A)
💻 Server Software
Paper
🎮 Minecraft Version
1.20.x
⭐ Slimefun version
This Server uses the following setup of Slimefun:
Paper git-Paper-405 (MC: 1.20.4)
Slimefun Dev - 1136
Metrics-Module #29
Java 17
Installed Addons: (33)
MiniBlocks vDEV - 4 (git f7a34b6e)
Networks vDEV - 50 (git 3de3c9d6)
CrystamaeHistoria vDEV - 81 (git 0c0efa95)
AureliumSkills vBeta 1.3.24
RelicsOfCthonia vDev - 12
FoxyMachines vDEV - 67 (git 0028aa93)
Quaptics vDev - 1
FNAmplifications vDev - 103
MetaBuilding v0
Furnished v1.0
MetaArrows v0
MetaRank v0.2
SlimeHUD vDev - 1
InfinityExpansion v1
SFCalc vDev - 38
Aureliumeta v0
MetaEvents v0
SlimeTinker vDEV - 84 (git 2c9f6155)
SpiritsUnchained vDev - 24
TranscEndence vDEV - 41 (git 98d7d47e)
Galactifun vDEV - 76 (git aa6414a8)
MetaStory v0
CMI v9.6.10.0
FluffyMachines vDev - 4
MetaMachines v0.7
Cultivation v1.0.0
MetaUtils v${project.version}
EcoPower vDEV - 5 (git 5c1ecd68)
MetaGuide v0
WorldEditSlimefun vUNOFFICIAL
Netheopoiesis vMODIFIED
DailyRewards v1.0-SNAPSHOT
Aircraft v0
🧭 Other plugins
Afaik not related to other plugins
Can confirm if an outside source cancels either the PlayerInteractEvent or the PlayerRightClickEvent, it does not care and still fires both items. I've made a patch solution in a separate plugin that just closes the backpack when its dropped, idk how we'd fix this specifically
Reproductions steps are pretty unclear.
If i right click in the inventory nothing happens.
Reproductions steps are pretty unclear. If i right click in the inventory nothing happens.
By right click I mean right click to open the inventory, after that you can see the behavior, you can put the backpack in it self, you can drop the backpack on the floor you can do literally anything you are not supposed to be able to do.
This then seems fixed in the latest version i cant repro it
latest as in the PR you made or wdym?
Can you test with #4134?
Can confirm not fixed on latest build, tried with addons and without and both times the bug worked
Edit: (here is sf versions)
This Server uses the following setup of Slimefun:
Paper git-Paper-365 (MC: 1.20.4)
Slimefun Dev - 1139
Metrics-Module #29
Java 17
No Addons installed
Paper git-Paper-496 (MC: 1.20.4)
Slimefun Dev - 1145
Java 17
I can't reproduce it either
I'll try again after school using the latest paper builds and I'll let you know if it's still an issue
I'll try again after school using the latest paper builds and I'll let you know if it's still an issue
I guess I didn't update but when I did this I believe the issue still occurred, I'll check again shortly though