[Bug] Plugin wont load
ArtificialTruth opened this issue · 62 comments
I'm getting this error again on plugin load:
http://pastebin.com/0xtfijVw
I've created a zip of my spigot jar, and folders: https://mega.nz/#!sgRHXZqB!Y-hAgUBtMps_6HhJy3_ysWnl3u806bjEyNbNS-r3ymo
The way arenas are stored was completely rewrote in the last version (not published yet), so this is probably no longer a problem. Reopen if needed when tested with the new version (when it will be published of course).
- How did you load it? By starting the server?
- Was it the first time to load the server or was there config already?
- Starting the server
- Config was there already.
I have re-uploaded it https://mega.nz/#!sgRHXZqB!Y-hAgUBtMps_6HhJy3_ysWnl3u806bjEyNbNS-r3ymo
Assigning @AmauryCarrade to fix this - just located the problem but I couldn't work out how to fix it...
When the plugin loads and the serialized Arenas are read from setup.yml, any Arena that still exists in the setup.yml, but the arena's world file is deleted will cause this error. We need to detect this (i.e. if corner1 has a null value) and print a message to the console saying "Skipping arena because its world no longer exists."
I can't figure out how to do this so I'd appreciate if you'd do it please ;)
Hey, thank you so much for taking time to find the problem!
However as far as I can see none of my worlds have been deleted.
Well, Lobby2.0 is a unfortunate name I'll give you that, but it definitely
exists.
I made it load by deleting the last arena, we'll see if it still works in a few days.
Seems that fixed your problem? Would I be right in thinking that?
If so, we just need @AmauryCarrade to implement the auto-fix to prevent arenas being loaded when their world no longer exists.
I will review and fix this as soon as possible. This said, I'm pretty busy this time but I'll do that when possible.
No, because when the server will restart, the « world2 » will be generated, and this world will be returned by Bukkit.getWorlds().get(0).
So this will not be a problem, the arena will be switched to world2.
This said, we may also delete the arena in these cases. I don't know what the better solution is. The first one (arena moved to the default world) allows the server owner to edit the arena.yml file to change the name of the world when it's back. That's why I implemented this solution.
@pgmann @TheOnlyRealTGS Implemented, see above (if you are on GitHub) or the Jenkins builds.
@TheOnlyRealTGS Can you try with this? It should autofix the arena file by using the default world if a world is missing. Can you try that and send me the log?
Your CI server? You changed the CI server? That's why the builds are no longer automatically done on my Jenkins server?
Yes, I was experimenting with openshift and discovered I could host a CI
server on it on a diy cartridge.
See it here: http://ci.pgmann.cf/
I wanted to see if it was up to much, but if it keeps crashing I'll just go
back to your server (it's really just a test to see if it works for a
while).
On Jun 5, 2015 3:04 PM, "Amaury Carrade" [email protected] wrote:
Your CI server? You changed the CI server? That's why the builds are no
longer automatically done on my Jenkins server?—
Reply to this email directly or view it on GitHub
#50 (comment)
.
No problem eh, of course, but you can have two hooks, one for each server, so both of them build the plugin :) .
So, this happened.. http://pastebin.com/FrsQL8cz
Looks like this:
07:07:59 [INFO] ~~ Arenas ~~
07:07:59 [INFO] KitBattle - Lobby: 186;76;307
07:07:59 [INFO] HungerGames3 - Lobby: -1;13;0
07:07:59 [INFO] HungerGames14 - Lobby: 15;69;24
07:07:59 [INFO] HungerGames9 - Lobby: 475;25;723
07:07:59 [INFO] HungerGames15 - Lobby: 659;10;-1881
07:07:59 [INFO] HungerGames4 - Lobby: 0;37;-3
07:07:59 [INFO] HungerGames12 - Lobby: -4565;60;592
07:07:59 [INFO] HungerGames5 - Lobby: 0;32;0
07:07:59 [INFO] HungerGames8 - Lobby: 1;25;5
07:07:59 [INFO] HungerGames7 - Lobby: 15;72;24
07:07:59 [INFO] HungerGames11 - Lobby: 1;103;0
07:07:59 [INFO] HungerGames2 - Lobby: 0;21;0
07:07:59 [INFO] HungerGames13 - Lobby: 24;75;-20
07:07:59 [INFO] HungerGames1 - Lobby: -1577;60;-611
07:07:59 [INFO] HungerGames6 - Lobby: 29;74;48
07:07:59 [INFO] HungerGames10 - Lobby: -1218;64;186
But teleporting to any arenas teleports me to (right? I think) cords, but the wrong world (the one that the main lobby is in, (Lobby2.0).
Give it a test. I've tested it and it does fix arena world deletion, renaming, etc. It also works for arena worlds.
Build 7 on my CI server: http://ci.pgmann.cf/job/SpectatorPlus/lastSuccessfulBuild/artifact/SpectatorPlus/target/SpectatorPlus-B2.1.jar
Seems like the plugin force changes the correct original world name to the world where the lobby is.
It seems all my world names changed, I changed them back. but I think it works now. Will report back if it doesn't.
Okay, after I restarted it said "KitPvP" doesn't exist (it does), and therefore it didn't load the arena.
What now? Maybe do so the plugin loads post [INFO] Done (5.036s)! For help, type "help" or "?" (not sure what it's called, something something bukkitapi)
Please include a bit more detail... do you have the world folder KitPvP (case sensitive) still in your server folder? Did you change anything between server loads? Do you have any plugins that might have changed the world? And, can you travel to the KitPvP world in game when SpectatorPlus says it can't be found?
Also, try using /spec reload or restart the server to see if it always says this or just once.
Please include a bit more detail... do you have the world folder KitPvP (case sensitive) still in your server folder?
Yep
Did you change anything between server loads?
Don't think so
Do you have any plugins that might have changed the world?
No
And, can you travel to the KitPvP world in game when SpectatorPlus says it can't be found?
Yep
And I already restarted the server, and /spec reload fixed it.
So again, maybe you need to run the check for arenas, post-enable?
Perhaps. Can you try a restart (maybe even a couple?) and see if that breaks anything again? That would confirm the plugin is checking which worlds are loaded too soon.
My server will restart in 12 hours, can't do it now while people are online.
Okay, I guess we've nailed down the bug then. I'll work on a fix.
Out of interest, was it the exact same world, KitPvP?
So I deleted all arenas exept one, and downgraded to 2.1
Getting this error:
http://pastebin.com/q7aE6HTX
Meh, sort of... I'm developing an app for Android at the moment, but I'll
probably work on this plugin again before too long...
On Sun, 16 Aug 2015 9:58 am TheOnlyRealTGS [email protected] wrote:
Hey, a month has passed, I'm wondering if this plugin is still alive? :)
—
Reply to this email directly or view it on GitHub
#50 (comment)
.
Thanks! If you want to see it so far, check out the project page of Group
Games on my website (http://pgmann.cf) - it may not look like much but it's
taken ages ;)
On Sun, 16 Aug 2015 10:58 am TheOnlyRealTGS [email protected]
wrote:
Okay, I wish you luck with the app!
—
Reply to this email directly or view it on GitHub
#50 (comment)
.
Really good job!
I myself coded a website from scratch too a few days ago! It's much better
than using templates, but ofc. isn't as pretty :)
2015-08-16 12:00 GMT+02:00 pgmann [email protected]:
Thanks! If you want to see it so far, check out the project page of Group
Games on my website (http://pgmann.cf) - it may not look like much but
it's
taken ages ;)On Sun, 16 Aug 2015 10:58 am TheOnlyRealTGS [email protected]
wrote:Okay, I wish you luck with the app!
—
Reply to this email directly or view it on GitHub
<
https://github.com/pgmann/SpectatorPlus/issues/50#issuecomment-131518084>.
—
Reply to this email directly or view it on GitHub
#50 (comment)
.