Collisions no longer removed for spectators

Question

Collisions no longer removed for spectators

AmauryCarrade opened this issue 9 years ago · 7 comments

AmauryCarrade commented 9 years ago

The collisions are no longer removed for spectators if the server is running Minecraft 1.9+ (tested with Minecraft 1.9.2, latest Spigot build).

I only seen this bug with animals, but I suppose the problem is the same with players—a potentially big issue because with Minecraft 1.9, players can push themselves so spectators would be able to push players on a cliff or similar.

pgmann · Answer 1 · 2016-05-07T15:48:01.000Z

Version 1.8 Spigot or Bukkit? All versions?

pgmann · Answer 2 · 2016-05-07T15:54:29.000Z

Aha! The setCollidesWithEntities method we use is deprecated. We should be using this instead: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/LivingEntity.html#setCollidable(boolean)

Deleted user · Answer 3 · 2016-05-07T11:46:34.000Z

It happens in servers running 1.8 as well. And the spectator wouldn't be able to push players, but yes vice-versa

Deleted user · Answer 4 · 2016-05-09T22:12:10.000Z

@pgmann 1.8.8 Spigot

pgmann · Answer 5 · 2016-05-25T18:07:16.000Z

Hmm, I can't seem to get the Reflection API to work... Can you test it please @AmauryCarrade?

pgmann · Answer 6 · 2016-05-25T18:16:04.000Z

player.setCollidable(collides); //works on spigot-api 1.9(.4)
Reflection.call(player.getClass(), player, "setCollidable", collides); //doesn't work

AmauryCarrade · Answer 7 · 2016-05-25T20:26:35.000Z

“Doesn't works” means?

The API guess native data types (like boolean instead of Boolean in the signature) sometimes wrongly; in this case you have to use the Java refection APIs directly, currently at least.

Share to