TARDIS

TARDIS

228k Downloads

Rebuild doesn't save the replaced block state like travel does

roberestarkk opened this issue ยท 4 comments

commented

Describe the bug

If you do a tardis rebuild, and you have landed in such a way that the TARDIS has replaced blocks, the next time the TARDIS demats, the blocks will not be put back

To Reproduce

  1. Dig a hole in a wall for your TARDIS so it's out of the way when it visits
  2. Travel your TARDIS and land it into the hole
  3. Save that location so that it can be returned to
  4. Travel the TARDIS away from the hole
  5. Fill in the hole
  6. Travel the TARDIS back to the hole
  7. Hide the TARDIS (replaced blocks come back)
  8. Rebuild the TARDIS
  9. Hide the TARDIS again (replaced blocks don't come back)

Screenshots

https://youtu.be/u_4paeUrFzM

Log files

No related errors.
Logs which reference TARDIS are:

[09:01:13] [Server thread/INFO]: [TARDISChunkGenerator] Loading TARDISChunkGenerator v4.8.2
[09:01:29] [Server thread/INFO]: [TARDISWeepingAngels] Loading TARDISWeepingAngels v3.5.0
[09:01:29] [Server thread/INFO]: [TARDIS] Loading TARDIS v4.8.2-b2402
[09:01:31] [Server thread/INFO]: [TARDISChunkGenerator] Enabling TARDISChunkGenerator v4.8.2
[09:01:31] [Server thread/INFO]: [TARDISChunkGenerator] Adding custom biome for planet Gallifrey...
[09:01:31] [Server thread/INFO]: [TARDISChunkGenerator] Adding custom biome for planet Skaro...
[09:01:31] [Server thread/INFO]: [TARDISChunkGenerator] Starting filtered logging for TARDIS plugins...
[09:01:31] [Server thread/INFO]: [TARDISChunkGenerator] Log file located at 'plugins/TARDIS/filtered.log'
[09:01:48] [Server thread/INFO]: [TARDISWeepingAngels] Enabling TARDISWeepingAngels v3.5.0
[09:01:49] [Server thread/INFO]: [TARDIS] Enabling TARDIS v4.8.2-b2402
[09:01:49] [Server thread/INFO]: [TARDIS] Debug: Hooking into TARDISChunkGenerator!
[09:01:49] [Server thread/WARN]: TARDIS failed to get the version for WorldGuard.
[09:01:49] [Server thread/INFO]: [TARDIS] Updated condensables.yml
[09:01:49] [Server thread/INFO]: [TARDIS] Loading language: ENGLISH
[09:01:49] [Server thread/INFO]: [TARDIS] Attempting to load world: 'TARDIS_TimeVortex'
[09:01:49] [Server thread/INFO]: -------- World Settings For [TARDIS_TimeVortex] --------
[09:01:50] [Server thread/INFO]: [WorldGuard] (TARDIS_TimeVortex) TNT ignition is PERMITTED.
[09:01:50] [Server thread/INFO]: [WorldGuard] (TARDIS_TimeVortex) Lighters are PERMITTED.
[09:01:50] [Server thread/INFO]: [WorldGuard] (TARDIS_TimeVortex) Lava fire is PERMITTED.
[09:01:50] [Server thread/INFO]: [WorldGuard] (TARDIS_TimeVortex) Fire spread is UNRESTRICTED.
[09:01:50] [Server thread/INFO]: [WorldGuard] Loaded configuration for world 'TARDIS_TimeVortex'
[09:01:50] [Server thread/INFO]: [dynmap] Loaded 3 maps of world 'TARDIS_TimeVortex'.
[09:01:51] [Server thread/INFO]: [TARDIS] Debug: Skaro enabled, registering planet event listeners
[09:01:51] [Server thread/INFO]: [TARDIS] Debug: Siluria enabled, registering planet event listeners
[09:01:51] [Server thread/INFO]: [TARDIS] Debug: Gallifrey enabled, registering planet event listeners
[09:01:51] [Server thread/INFO]: [TARDIS] Debug: Hooking into WorldGuard!
[09:01:52] [Server thread/INFO]: [TARDIS] Debug: Creating markers for Dynmap.
[09:01:52] [Server thread/INFO]: [TARDIS] Loaded 2 portals.
[09:01:52] [Server thread/INFO]: [TARDIS] Loaded 1 dispersed Police Boxes.
[09:01:52] [Server thread/INFO]: [TARDIS] Debug: Starting force fields with a range of 8 blocks.
[09:01:52] [Server thread/INFO]: [TARDIS] Debug: Logging block changes with CoreProtect.
[09:01:52] [Server thread/INFO]: [TARDIS] Connecting to CoreProtect
[09:01:54] [Craft Scheduler Thread - 7 - TARDIS/INFO]: [TARDIS] There is a new TARDIS build! You are using #2402, the latest build is #2403!
[09:01:54] [Craft Scheduler Thread - 7 - TARDIS/INFO]: [TARDIS] Visit http://tardisjenkins.duckdns.org:8080/job/TARDIS/ or run the '/tardisadmin update_plugins' command
[09:02:02] [Server thread/INFO]: [TARDIS] Debug: Advancement 'tardis:tardis' exists :)
[11:23:27] [Server thread/INFO]: RobereStarkk[/49.186.1.54:52167] logged in with entity id 66474 at ([TARDIS_TimeVortex]512.4195368403603, 70.0, 3580.5232796347236)
[11:24:18] [Server thread/WARN]: [TARDIS] Loaded class nl.rutgerkok.blocklocker.BlockLockerAPIv2 from BlockLocker v1.10.2 which is not a depend, softdepend or loadbefore of this plugin.
[12:07:35] [Server thread/INFO]: [TARDIS] Server version: git-Paper-169 (MC: 1.18.1)
[12:07:35] [Server thread/INFO]: [TARDIS] TARDIS version: 4.8.2-b2402
[12:07:35] [Server thread/INFO]: [TARDIS] TARDISChunkGenerator version: 4.8.2
[12:07:35] [Server thread/INFO]: [TARDIS] dynmap version: 3.3-beta-1-564
[12:07:35] [Server thread/INFO]: [TARDIS] Essentials version: 2.19.2
[12:07:35] [Server thread/INFO]: [TARDIS] WorldGuard version: 7.0.6+1cff55f
[12:07:35] [Server thread/INFO]: [TARDIS] CoreProtect version: 20.1
[12:07:35] [Server thread/INFO]: [TARDIS] TARDISWeepingAngels version: 3.5.0
[12:07:35] [Server thread/INFO]: [TARDIS] Checking for new TARDIS builds...
[12:07:37] [Craft Scheduler Thread - 879 - TARDIS/INFO]: [TARDIS] You are 1 builds behind! Type /tadmin update_plugins to update!

'/tardis version' output

[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] Server version: git-Paper-169 (MC: 1.18.1)
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] TARDIS version: 4.8.2-b2402
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] TARDISChunkGenerator version: 4.8.2
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] dynmap version: 3.3-beta-1-564
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] Essentials version: 2.19.2
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] WorldGuard version: 7.0.6+1cff55f
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] CoreProtect version: 20.1
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] TARDISWeepingAngels version: 3.5.0
[Wed, 16. Feb 2022 12:07:36 GMT INFO] [TARDIS] Checking for new TARDIS builds...
[Wed, 16. Feb 2022 12:07:41 GMT INFO] [TARDIS] You are 1 builds behind! Type /tadmin update_plugins to update!

commented

Seems like a strange edge case to me... do you do this often?

commented

I'll have to do some testing as rebuilding has been problematic in the past (leaving ghost TARDISes behind), which is why it doesn't remember the blocks.

commented

Do I toggle between built and hidden often? Somewhat
Do I save locations which replace blocks when you visit them so as to not take up valuable empty space often? Somewhat
Do I do both at the same time? Admittedly, almost never, probably only because I was testing the below-door-HADS.

But that doesn't mean other people won't, or that I won't encounter a situation in which I start having to do it more often.
Plus there's also the scenario where you hide your TARDIS where you've landed it 'normally' and someone else then later decides to build there and you don't realise.

commented

Should work as expected now build 2418 or higher