Jettisoned special rooms does not remove associated functions
techno156 opened this issue ยท 5 comments
Describe the bug
If you jettison rooms that have a particular binding, such as the exterior renderer, the empty space where the room was is still connected to those functions.
For example, if you jettison the exterior renderer (but don't create a new one), the space where the renderer was still acts as though the renderer was present, placing blocks appropriately. This can cause unexpected behaviour if you decided to put another room in that space.
To Reproduce
- Spawn Exterior Render Room
- Jettison Render Room
- [Optional] Place new room into same location
- Run the exterior scanner. Room/contents are deleted and replaced with the renderer's contents.
Screenshots
Log files
https://gist.github.com/techno156/93168311c0c3f122b28c5bd520af477d
'/tardis version' output
[19:41:08] [Render thread/INFO]: [System] [CHAT] [TARDIS] Server version: git-Paper-389 (MC: 1.20.4)
[19:41:08] [Render thread/INFO]: [System] [CHAT] [TARDIS] TARDIS version: 5.3.0-b2775
[19:41:08] [Render thread/INFO]: [System] [CHAT] [TARDIS] Checking for new TARDIS builds...
[19:41:09] [Render thread/INFO]: [System] [CHAT] [TARDIS] You are running the latest version!
It should be removing the renderer data:
https://github.com/eccentricdevotion/TARDIS/blob/master/src/main/java/me/eccentric_nz/TARDIS/ARS/TARDISARSJettisonRunnable.java#L137
Will need to test...
Can't reproduce on my server, renderer records are removed as expected.
How are you jettisoning the room?
Can't reproduce on my server, renderer records are removed as expected. How are you jettisoning the room?
The room was created and jettisoned using the /tardis commands. I have not tested it using the ARS.
Not sure if the Zero room is relevant as it can't be jettisoned...
That one is a mistake on my part, since it turned out one of the servers I used for testing has a separate zero room variant that makes it a regular room (with the same functions) in the time vortex world, rather than one that exists in a separate dimension.