TARDIS

TARDIS

Bukkit Plugins
228k Downloads

Rename `/tardis home` command to `sethome`

Closed this issue ยท 2 comments

commented

Describe the feature request

I propose the /tardis home command (used to set the TARDIS home) be renamed to /tardis sethome to more accurately describe what the command does. I can't remember how many times myself and other players have accidentally typed it instead of /ttravel home and lost our TARDIS home position.

I don't think there are many players who set their TARDIS home so often that they've committed the command to muscle memory, so we wouldn't be losing much by changing the command. Players should be able to adapt to the new command fairly easily.

Describe alternatives you've considered

Leave the command as-is and deal with the consequences of mis-typing it.

commented

There is already a sethome alias for home, so just removing home should suffice...

commented

That build seems to work. However, it doesn't seem to be checking the tardis.home permission like the wiki claims, just the tardis.timetravel permission:

Image

Image

This is backed up by the source code only containing a permissions check for the timetravel permission:

TARDIS/Core/src/main/java/me/eccentric_nz/TARDIS/commands/tardis/TARDISSetHomeCommand.java

Lines 49 to 55 in 9fde59d

boolean setHome(Player player, String[] args) {
if (TARDISPermission.hasPermission(player, "tardis.timetravel")) {
ResultSetTardisID rs = new ResultSetTardisID(plugin);
if (!rs.fromUUID(player.getUniqueId().toString())) {
plugin.getMessenger().send(player, TardisModule.TARDIS, "NOT_A_TIMELORD");
return false;
}

Maybe the wiki should just be updated to remove the tardis.home permission? It doesn't seem to be used anywhere else.