Terrain Control

Terrain Control

235k Downloads

/tc map

Jonas438 opened this issue · 23 comments

commented

If I use the command '/tc map' I get this Error:
http://pastebin.com/fpUpXkUh

I´m using CraftBukkit 1.6.2 Build 2820.

commented

Hi there,

I just tested the map command with the CB build you listed and the latest build of TC and a fairly complex map and It worked. If you haven't already, go ahead and update your TC jar.

If that isn't working, Please temporarily replace your TC jar with this debug version I built for you :D
http://www.div-element.com/TerrainControl_Bukkit_JONAS_DEBUG.jar
and provide another pastebin of the logs.

I'm thinking you are probably in a world that was generated with some custom biomes that are no longer listed in your worldConfig or your world isnt loading properly. The 21 from the logs is the number of default biomes in vanilla MC.

Time
commented

Hi Time,

thanks for your answer and your debug build :)
I tryed again on a new Minecraft Server with the same CraftBukkit-Build (new downloaded) at the last release Build but I get the same Error.
Your Debug Build works fine and created images, but it create a very big server.log file (147 MB).
My Browser crash every time, when I will paste the log into pastebin, so I packed it into a ZIP-File and uploaded is on my Webspace:
http://www.freezzingcraft.de/serverlog.zip

Jonas

commented

Hey so, did the maps generate properly but still give you an error, or did it give you an error and the maps failed to generate?

commented

Hi,
the server doesn´t puted out errors, while generating the maps.
I tested it with 2 maps and I always get an error, when I try to create images with the last recommendend Version of TerrainControll. Only your debug build works fine.

Jonas

commented

Alright, that's good to know.

The debug build that works for you is actually ahead by a few commits. I will finalize what I have been working on and ask one of the guys if they can update dev.bukkit and the release page so others who would have run into this exception, will not. In the mean time, I have made a new jar for you that will not make a lot of log noise. It will, however, only be good for bukkit as I am still trying to work out the forge side of compiling :\ Hope that isn't a problem :D

Sneak Preview Jar: http://www.div-element.com/TerrainControl_Bukkit-2.4.15-SNAPSHOT.jar

As far as the root problem goes, I am still not sure why your BukkitWorld is coming back as null. That IS the reason you were getting the out of bounds error. Maybe @Wickth or @rutgerkok have an idea as to why that would happen.

commented

Okay, I hope that you can find the reason. If you want, I can send you our map, but not here. I will not publish it.
That build works fine too ;)

commented

Yea, I was reluctant to ask for it since I know people like to keep their maps and settings secret (myself included, hehe) but that would be really useful since I haven't been able to reproduce the problem yet xD Will email work?

commented

Yes. I will send you the map from my test server. It have the same Error.

commented

I tried to send you a mail from 2 mail accounts, but I always get an error.
I tested it with 2 mail accounts:

This is an automatically generated Delivery Status Notification.
Delivery to the following recipients failed.
[email protected]

and

This is the mail system at host freezzingcraft.de.
I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.
For further assistance, please send mail to postmaster.
If you do so, please include this problem report. You can
delete your own text from the attached returned message.
The mail system
[email protected]: host mail.cyber-cache.com[98.172.27.70] said: 554
invalid message content (#5.3.2) (in reply to end of DATA command)

Something is false at your mail adress.

commented

The world from my Test Server used the default Minecraft generator. You can see in my log file, that I only use the default worldgeneratorat my test server.

At my Dedicated Server I used the cleanroomgenerator first, but since today I use the Minecraft generator with a edited level.dat. I don´t think that my level.dat is corrupt, because the same error is at the new generated map from the test server too. I don´t have problems with the default worldgenerator and the modified level.dat.

commented

Did you have worlds generated by default generator ?

commented
commented

I have send you a mail with a link to the ZIP-Archiv on my Webspace.

commented

Another question.. You have some error when generating map form console and client?
And if you using client you are in TC world?

commented

I tested it with the client and the console.
When I do /tc map from the client, I only see "Generating map...". The Error I only can see in the console.
When I tried to do /tc map world from the console I can see "Generating map..." and from the next line the known error.

commented

I got it!

Ok, so with the current release of TC, if you haven't configured your world in the bukkit.yml file like this:

worlds:
  world:
    generator: TerrainControl

TC never gets a bukkitWorld object for it which, in the code, leaves the biomeColors array as the default colors. This means that with the current release of TC you CAN NOT use \tc map to map a world not assigned to TC for generation.

Now, with the changes I made in the debug version, it simply skips any index that is out of the array bounds...So, for now, either add your world to bukkit.yml to use the official release or continue using the snapshot I linked :D

commented

Note: When I added those three lines to the bukkit.yml file, the already generated world seemed to be completely regenerated when I re-entered it, so be careful with existing worlds. I recommend doing a backup before making any such changes :)

commented

oh, I forgot to add that to bukkit.yml file. I will add it.
I do backups every day and particularly when I make big or dangerous changes.
Thanks for your help! ;)

commented

I was able to get your world to generate maps without a problem. I think it is most likely going to be something in the way you have TC configured that is making this act weird. If you don't mind sending your entire server folder from your test server I could take an in-depth look at what is going on. It definitely isn't the world file though.

commented

Greetings,

I get this same error when using /tc map. It is not clear to me from this thread if there is a aversion in which this is fixed. Are there development builds somewhere?

Thanks

tc map world137
21:43:39 [INFO] Generating map...
21:43:42 [INFO] 3%
21:43:44 [INFO] 6%
21:43:46 [INFO] 10%
21:43:48 [INFO] 14%
21:43:50 [INFO] 19%
21:43:52 [INFO] 23%
21:43:54 [INFO] 27%
21:43:56 [INFO] 32%
21:43:58 [INFO] 36%
21:44:00 [INFO] 40%
21:44:02 [INFO] 45%
21:44:04 [INFO] 49%
21:44:06 [INFO] 52%
21:44:08 [INFO] 57%
21:44:10 [INFO] 60%
21:44:12 [INFO] 64%
21:44:12 [SEVERE] java.lang.ArrayIndexOutOfBoundsException: 21
21:44:12 [SEVERE] at com.khorn.terraincontrol.bukkit.MapWriter.run(MapWriter.java:150)
21:44:12 [SEVERE] at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:53)
21:44:12 [SEVERE] at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53)
21:44:12 [SEVERE] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
21:44:12 [SEVERE] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
21:44:12 [SEVERE] at java.lang.Thread.run(Thread.java:722)

commented

Nevermind, the "Sneak Preview" linked fixed it.

commented

@CosmicVoyager Make sure your world is added to the bukkit.yml file as per the wiki.

commented

Fixed by commit ae7300d