Terrain Control

Terrain Control

235k Downloads

BiomeConfig.ini - file extension changes

Timethor opened this issue ยท 13 comments

commented

@SimSonic @Dilvish

This issue is to address the topic of amending the way biome configs are found.

Currently, only files in the form BiomenameBiomeConfig.ini are accepted, where BiomeConfig.ini is attached to the Biomename to determine the file name.

There are two phases to improvement proposed. The first of which is already being implemented, subject to change. The second can be included given it garners support:


Part 1:

A number of acceptable extensions are hardcoded into TC. Ex:
BiomeConfig.ini, .bc, .biome, .bc.ini, .biome.ini
as well as a default value that will remain as the original, BiomeConfig.ini unless there is some agreement on a new default.

TC will attempt to load a biome by taking the biome name and going down the list of acceptable extensions until a file is found. If no biome is found with the acceptable extensions, the default will be used... and that file will be created.


Part 2:

In the pluginConfig:

  • Option to convert non-default extensions to defaults.
  • Option to change what is considered the default.
  • Option to list custom Biome extensions to be used, in addition to the hardcoded ones

Give me your comments, suggestions, additions, etc :D

commented

I'm thinking quite the opposite: only one option for something. If we allow many different ways of doing something, config layouts will vary and it will be more difficult to read someone else's configs. ๐Ÿ˜ƒ

commented

I'm agree with @Timethor, this doesn't need options, just a set of acceptable extensions.

commented

no no, not changing the config contents... we would just be allowing a set of extensions, and setting one as TC's default for when we create file automatically.. then people can choose if they like .bc or .bc.ini etc... anything outside that will not be accepted. Then allow people to just change the default if they dont like something... This also allows us to be backwards compatible while not forcing anyone to switch to a new extension :D

commented

Also, I had an auto-rename option that i was testing and it didnt rename the files as it was supposed to ... Not sure if it's just me being incompetent or it was b/c the files were being read from when the rename was executing or something like that... I did get renaming of folders to work in a relatively reliable way though...so BiomeConfigs will be auto-renamed to WorldBiomes now...

commented

.bc.ini should be the best way, cause it both shortest and .ini.

commented

@Timethor, I think suffixes like

BiomeConfig.ini, .bc, .biome, .bc.ini, .biome.ini

are enough. But may be change default value from BiomeConfig.ini to .bc? Compatibility will be the same.
Part 2 can get their fans but not today.

I have another idea, but don't know about its importance. We have GlobalObjects (and GlobalBiomes?), WorldObjects and BiomeConfigs ( this should be called WorldBiomes in new terminology, lol:) ) and why not allow users to create folder in /BiomeConfigs/%Biome%/ and put bo2s/bo3s into it without editing configs? In addition to resources Tree and CustomObject(...).

commented

@SimSonic I agree mostly.

The BiomeConfigs folder has bugged me since I started working on this project. I will look into making WorldBiomes a thing.

My only concern with making the default extension .bc is that clicking on the file with that extension will pop up in windows as an unknown file type. Yes, you and I know how to open it for editing... But less experienced users might have difficulty opening and editing the file. It is, in fact, an ini file... So i feel if anything it should be either bc.ini or biome.ini

Biome Specific BO2/BO3 folders is an interesting idea... I feel like the majority of people use a given bo2/3 file in more than one biome, but I really like the idea of it auto-loading BO's from the folder though...

commented

Agreed. Haha, this kinda makes me want to do: WorldConfig.ini => WorldName.wc.ini ... jk.

commented

yea, but idk >.> too many changes for one day...

commented

Keep it for later update. This is only decoration change.

commented

%worldname%.wc.ini ...

commented

Why not just accept .bc and .wc? Old files will automatically be renamed. (Same happened to the BOBPlugins folder.)

Don't worry about Windows users not being able to open files: Notepad is one of the choices that pops up in the "Which program?" dialog box. We just tell users to use that. They got the same dialog box for yml files. It also gives them some experience for the BOB files.

commented

Ok, if you think it wont be a problem i'm in agreement. I just didn't want to alienate any potential users while giving people the most options while also not killing myself... ๐Ÿ˜„