Terrain Control

Terrain Control

235k Downloads

MCPC+ 1.7.2 Plugin Compatibility

wnewbery opened this issue ยท 4 comments

commented

Been trying to get TerrainControl and MCPC+ working for 1.7.2 this weekend, and found a few issues.

Firstly Bukkit.getServer was always returning "null (MC: 1.7.2)" for me, so the MCPC+ detection fails (see MinecraftPortCentral/Cauldron#710).

Secondly TCChunkGenerator.generateBlockSections gets called before Init (btw, why the capital I?), and so crashes (at least when creating an entirely new world). Just making that function call Init appears to work.

This is the stack trace for the first time generateBlockSections gets called on a new world. I added the actual function names since I couldn't get the eclipse thread stack trace to display them, even when it went to the correct deobfuscated source locations... Not sure how this differs from CraftBukkit, but something must be different.

TCChunkGenerator.generateBlockSections(World, Random, int, int, ChunkGenerator$BiomeGrid) line: 57
CustomChunkGenerator.func_73154_d(int, int) line: 95    (provideChunk)
ChunkProviderServer.getChunkAt(int, int, Runnable) line: 183    (getChunkAt)
ChunkProviderServer.func_73158_c(int, int) line: 137    (loadChunk)
ChunkProviderServer.func_73154_d(int, int) line: 239    (provideChunk)
WorldServer(World).func_72964_e(int, int) line: 786     (getChunkFromChunkCoords)
WorldServer(World).func_147439_a(int, int, int) line: 688
WorldServer(World).func_147437_c(int, int, int) line: 708   
WorldServer(World).func_147474_b(int, int) line: 672    
WorldProviderSurface(WorldProvider).func_76566_a(int, int) line: 83     (canCoordinateBeSpawn)
WorldServer.func_73052_b(WorldSettings) line: 1006  (createSpawnPosition)
WorldServer.func_72963_a(WorldSettings) line: 949   (initialize)
WorldServer(World).<init>(ISaveHandler, String, WorldSettings, WorldProvider, Profiler, ChunkGenerator, World$Environment) line: 478
WorldServer.<init>(MinecraftServer, ISaveHandler, String, int, WorldSettings, Profiler, World$Environment, ChunkGenerator) line: 157
DedicatedServer(MinecraftServer).func_71247_a(String, String, long, WorldType, String) line: 347    (loadAllWorlds, just after calling this.server.getGenerator).
DedicatedServer.func_71197_b() line: 291
DedicatedServer(MinecraftServer).run() line: 622
Thread.run() line: not available

Was using http://ci.md-5.net/job/MCPC-Plus/29/ as the server.

commented

Noted, but at the moment MCPC+'s download server is offline for me.

commented

The detection issue has been fixed in MCPC+ 1.7.2 build 41

commented

Thanks, @bloodmc.

commented

You can now use TC as a Bukkit plugin on MCPC+. Using it as a Forge mod is not yet possible.

0f0d271