TriggerReactor

TriggerReactor

24.6k Downloads

make every trigger have a unique name, then unify the command format

gerzytet opened this issue · 2 comments

commented

Currently, when a click or walk trigger is first created, it has no name. The prefixing feature was a step in the right direction, allowing manual labeling.
I’m suggesting that we take it one step further and require a unique prefix for every new click and walk trigger. This will allow click/walk triggers to be looked up by name and free users from having to be at the trigger’s location to interact with it.
If every click/walk trigger has a prefix, it also makes big #241 irrelevant. As long as we disallow - characters in prefixes, there’s no ambiguity, since we know for sure that the first - ends the prefix, even if the world name has them too.
As part of the change, we would need to assign names to old triggers that don’t have them and sort out duplicates. We will also need to decide what tools like copy/paste should do to the prefix.

Advantages:
Ability to edit the trigger without being there
Much more convenient to label triggers
Fixes #241

The second thing I’m suggesting is a more unified command format. It would be ideal if all the trigger commands followed this format:
/trg <operation...>
Some triggers already follow this format, like inventory and area.
However, this format isn’t possible for click and walk triggers unless we require names. That’s why these 2 suggestions are together.

Advantages:
More intuitive command system
Allows us to greatly simplify onCommand, and the documentation on the commands

commented

Sounds good

Can you divide the second suggestion into its own issue?

commented

In the meantime, we could change the command and walk commands from:

  • /trg walk {script}
  • /trg click {script}

To

  • /trg walk {name} {script}
  • /trg click {name} {script}

This would simply add the prefixes to the files when they are first created.