TriggerReactor

TriggerReactor

24.6k Downloads

GlobalVariableManager doesn't block for server shutdown procedure

wysohn opened this issue ยท 0 comments

commented

(https://github.com/TriggerReactor/TriggerReactor/blob/2f1cbf4b23c1ebaf8716ac7f7c347af051d66aca/core/src/main/java/io/github/wysohn/triggerreactor/core/manager/GlobalVariableManager.java#L32)]

GlobalVariableManager does not override disable() method, so when the server shuts down with the stop command, the main server thread assumes that TRG is fully disabled, yet the GlobalVariableManager might be still writing something to the disk.

This can cause all the global variables to be lost if GlobalVariableManager happens to be writing something to the disk, and the main server thread forces the saving thread to shut down before the job is done.