TriggerReactor

TriggerReactor

24.6k Downloads

COMMAND trg inventory .... item uses wrong index

MidnightSugar opened this issue ยท 4 comments

commented

The command /trg inventory ... item always uses slot before the actual slot number which is confusing. This is because it starts at index 1 instead of 0.

commented

I remember this was changed because people count index from 1, not 0, so I'm not sure which one is a better option for everyone

Since it is used in the command, it kind of makes sense to have it starting from 1, but also we use the "slot" variable to use index starting from 0, so we may want to be consistent on that

commented

I think everything should start from zero since that is the actual slot number. Row and column can start from 1 that makes sense. But it gets confusing when working with slots. As an example, I was setting up scripts for an item in slot 12. Using IF slot == 12, And I wanted to edit the item after so I used the command with index 13 and it deleted the item I had in index 12 and I had to redo it.

commented

So I have to keep track and be okay i need to do slot 13 so ill do slot 12 in the command. Gah its so confusing lol.

commented

I think unifying method of counting slots or row is better

As MidnightSuvar said, it's very confusing.

It's my two cents.