TriggerReactor

TriggerReactor

24.6k Downloads

Executors and Placeholders refactoring

son-daehyeon opened this issue ยท 12 comments

commented

What do you think?

commented

As we said in #475 (comment), it is a necessary task and inevitable. I couldn't do it because have no time, but I believe would be possible soon if we make a branch for that and push commits that worked on each other little by little.

commented

Oops, didn't mean to close it.

commented

Is there any branch created yet?
Actually, I've been refactoring since yesterday.

commented

No branches iirc yet

commented

@wysohn Could I create a new branch for refactorig?

commented

@wysohn Could I create a new branch for refactorig?

Yes, please! Make sure to use development as the base branch

commented

Note
Sponge API 8 was released in beta and they promised the API interface do not change. We should do divide Sponge project structure for 7 and 8 first if process Sponge also.

Here is a simple structure what I thought:

graph TD;
  TriggerReactorCore-->BukkitIntegratedAPI;
  TriggerReactorCore-->SpongeIntegratedAPI;
  BukkitIntegratedAPI-->id1[Legacy Bukkit];
  BukkitIntegratedAPI-->id2[Latest Bukkit];
  SpongeIntegratedAPI-->id3[Sponge API7];
  SpongeIntegratedAPI-->id4[Sponge API8];
Loading

/cc @Ioloolo

commented

Note
Sponge API 8 was released in beta and they promised the API interface do not change. We should do divide Sponge project structure for 7 and 8 first if process Sponge also.

^^^
nvm seems to be not related to this issue and is good to create a new ticket. ๐Ÿ˜…

commented

@Ioloolo Just quick question. Does this process resolves Issue #484 ?

Yes. This PR will ensure operation for all EXs.

commented

@Ioloolo Just quick question. Does this process resolves Issue #484 ?

commented

@Ioloolo Just quick question. Does this process resolves Issue #484 ?

Yes. This PR will ensure operation for all EXs.

Alright then, the Issue #484 will be closed and merged into this Issue #485

commented

Resolved by #486