Executors and Placeholders refactoring
son-daehyeon opened this issue ยท 12 comments
As we said in #475 (comment), it is a necessary task and inevitable. I couldn't do it because have no time, but I believe would be possible soon if we make a branch for that and push commits that worked on each other little by little.
Is there any branch created yet?
Actually, I've been refactoring since yesterday.
@wysohn Could I create a new branch for refactorig?
@wysohn Could I create a new branch for refactorig?
Yes, please! Make sure to use development
as the base branch
Note
Sponge API 8 was released in beta and they promised the API interface do not change. We should do divide Sponge project structure for 7 and 8 first if process Sponge also.
Here is a simple structure what I thought:
graph TD;
TriggerReactorCore-->BukkitIntegratedAPI;
TriggerReactorCore-->SpongeIntegratedAPI;
BukkitIntegratedAPI-->id1[Legacy Bukkit];
BukkitIntegratedAPI-->id2[Latest Bukkit];
SpongeIntegratedAPI-->id3[Sponge API7];
SpongeIntegratedAPI-->id4[Sponge API8];
/cc @Ioloolo
Note
Sponge API 8 was released in beta and they promised the API interface do not change. We should do divide Sponge project structure for 7 and 8 first if process Sponge also.
^^^
nvm seems to be not related to this issue and is good to create a new ticket. ๐
@Ioloolo Just quick question. Does this process resolves Issue #484 ?
Yes. This PR will ensure operation for all EXs.
@Ioloolo Just quick question. Does this process resolves Issue #484 ?
Resolved by #486