Vanish No Packet

Vanish No Packet

855k Downloads

Feature Request - Ability to disable/enable effects from configfile.

buddyboy1776 opened this issue ยท 3 comments

commented

It is possible to modify effects in config, but still not possible to get rid of them entirely ( at least I was unable to make it happen). Since toggle persistence, and I assume any per-user granularity has been pushed out to v4, could there at least be an ability in the config file to just turn effects on or off serverwide? Just a single flag for all effects would be enough. In any case thank you for writing this plugin!

commented

It's equally easy to turn effects on server-wide via perm node. For example, using permissions.yml to give everyone bats.

vanish.allthethings:
  default: true
  children:
    vanish.effects.bats: true
commented

Thank you for taking time to address my concerns. I think I'm missing something or was unclear. effects are on by default for ops. What I want is to turn effects OFF for ops. BTW It is customary to give ops one permission node: * Consider the alternative on a working server with 10-20 plugins.

Your suggestion, when applied to ops implies subtracting permssions from * Perhaps this is something that may be possible in some permissions manager, but MCMyAdmin, which is the standard dashboard given to gamehost customers seems to only understand "you haz, you don't haz" when interacting with permissions managers.

It just seems, given the real-world issues of servers in the field that tacking in a config line that would naturally live next to the place where you already get to pick how many lightning bolts you get in lightning mode would be the quick way to go until you can tackle writing the database code that gives you the per-user toggle persistence. If I am missing anything, let me know. I want ops to have noises chosen to be off/on at runtime. All ops per server can suffer under the same conditions.

commented

Effects are OFF by default for OPs. The * node is explicitly granting every single permission node ever, and should only be done if you actually want every single node every single plugin you use provides. Plugins granting nodes that even ops shouldn't have by default, such as VanishNoPacket, set those nodes to default to false even for OPs.

By granting the '*' node you are saying "Disregard that protection, I want it all anyway!" That is a dangerous statement to make, as you've observed with the effects.

I provide perm nodes instead of config values because it allows for per-user setting of what effects are granted on join. A config value does not provide such a level of control, and would be redundant if added to the existing system.

If you have further questions feel free to ask them.

Also on a related note, if you happen to be using PermissionsEx as your '*' node granting plugin (As there's only two plugins with that horrid hack), check out this document: http://goo.gl/MHhbl