Hello, can you please make it so, when player does /v fakequit or /v fakejoin, instead of messages, VanishNoPacket will call PlayerQuitEvent or PlayerJoinEvent?

Breaking tons of plugins?

VanishFakeJoinEvent, VanishFakeQuitEvent?

B

On 20 December 2013 03:20, Matt Baxter [email protected] wrote:

Breaking tons of plugins?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/529#issuecomment-30989549
.

We are doing this for our own plugins running on our own framework, through a small plugin bridge; https://github.com/Runsafe/VanishBridge

The fake quit/join events makes it harder to detect the difference between a real and fake quit, and also removes risk factors of misconfiguration giving admins away.

In my opinion, if you fake a quit, all plugins ought to handle it as if you quit - if some plugin needs to tell the difference, they ought to take special steps.

Vanishing is hiding from clients, not plugins running on the server. You should not lie to plugins about join/quit events unless you badly want to trigger a desync or plugin failures. It would be irresponsible of me to fire PlayerJoinEvent or PlayerQuitEvent.

Well, what if on every leave, there should be a sound played, and the fakequit doesnt play it :(

@rcl2748 The plug-in that is playing the sound should add Vanish support and check for a fake quit?

I'm happy to improve on the event that VNP does fire to provide the information necessary

@mbax It should already be sufficient enough. As @mortenn said above, our system uses your events to fire fake leave/join events to all our plug-ins therefore all the information is already there.