Vanish No Packet

Vanish No Packet

855k Downloads

1.9 incompatibility - plugin will not load

tmad40blue opened this issue ยท 13 comments

commented

Hi mbax, I realize that this might also be filed under "Spigot broke it, not my fault" but I thought I'd give it a shot anyway - the getOnlinePlayers() method is now deprecated and it's causing VNP to refuse to load. If you do decide to fix this then I would be very grateful. Thanks!

[09:35:41] [Server thread/INFO]: [VanishNoPacket] Enabling VanishNoPacket v3.19.1                                                                                                                                                                                                          
[09:35:41] [Server thread/ERROR]: Error occurred while enabling VanishNoPacket v3.19.1 (Is it up to date?)                                                                                                                                                                                                                    
java.lang.NoSuchMethodError: org.bukkit.Server.getOnlinePlayers()[Lorg/bukkit/entity/Player;                                                                                                                                                                                                                                  
        at org.kitteh.vanish.VanishPlugin.onEnable(VanishPlugin.java:327) ~[?:?]                                                                                                                                                                                                                                              
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:291) ~[spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                         
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                            
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                           
        at org.bukkit.craftbukkit.v1_9_R1.CraftServer.loadPlugin(CraftServer.java:361) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                
        at org.bukkit.craftbukkit.v1_9_R1.CraftServer.enablePlugins(CraftServer.java:321) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                             
        at net.minecraft.server.v1_9_R1.MinecraftServer.t(MinecraftServer.java:411) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.MinecraftServer.l(MinecraftServer.java:376) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.MinecraftServer.a(MinecraftServer.java:331) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                   
        at net.minecraft.server.v1_9_R1.DedicatedServer.init(DedicatedServer.java:269) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                
        at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:522) [spigot.jar:git-Spigot-604e046-69e196f]                                                                                                                                                                                                 
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
commented

"Spigot broke it, not my fault" ^_^

More accurately, they removed methods unnecessarily, breaking my stuff and that of many others.

Shame really, their only purpose at this point is to provide "the same" experience as Bukkit for folks who can't yet migrate to Sponge because they're waiting on those older plugins to arrive on the Sponge platform.

commented

Alright, thanks anyway. I'll manage somehow :P

commented

RIP

commented

Not the greatest thing I have read today. Do you have no plans to update this plugin again?

Also, how far along IS Sponge?

commented

Sponge is rather far along.

Curse are certainly taking their time approving the updated plugin, which works great on latest Bukkit.

commented

Great, thanks. Is CI enabled for VanishNoPacket, so I can grab it from there on my own?

commented

You can build it on your own. Alternately, Curse does publish publicly the pages of not-yet-reviewed files. Check out the URLs.

commented

Poked around and couldn't find a link on the VNP curse page. Perhaps you can only see it because you're a dev..? I know direct linking is a thing on Bukkit, if it is on Curse, could you link me the update page if it is not too much trouble?

commented

Like I said, gotta play with the URLs. I don't know how much of our old BukkitDev rules Curse follows/enforces but I'd rather not poke a rule I used to enforce.

commented

Update! It seems to have been approved.

commented

Seems to be working, but I get an internal error everytime I go into vanish mode.

commented

[20:14:54 ERROR]: Unhandled exception executing command 'vanish' in plugin VanishNoPacket v3.20 org.bukkit.command.CommandException: Unhandled exception executing command 'vanish' in plugin VanishNoPacket v3.20 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[Spigot.jar:git-Spigot-3af4605-ed8cef0] at com.earth2me.essentials.Essentials.onCommandEssentials(Essentials.java:417) [Essentials.jar:?] at com.earth2me.essentials.Essentials.onCommand(Essentials.java:402) [Essentials.jar:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at org.bukkit.craftbukkit.v1_9_R1.CraftServer.dispatchCommand(CraftServer.java:645) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.PlayerConnection.handleCommand(PlayerConnection.java:1313) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.PlayerConnection.a(PlayerConnection.java:1148) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.PlayerConnectionUtils$1.run(SourceFile:13) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_72] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_72] at net.minecraft.server.v1_9_R1.SystemUtils.a(SourceFile:45) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.MinecraftServer.D(MinecraftServer.java:721) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.DedicatedServer.D(DedicatedServer.java:400) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.MinecraftServer.C(MinecraftServer.java:660) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:559) [Spigot.jar:git-Spigot-3af4605-ed8cef0] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72] Caused by: java.lang.NullPointerException at org.dynmap.bukkit.DynmapPlugin.assertPlayerInvisibility(DynmapPlugin.java:1503) ~[?:?] at org.kitteh.vanish.hooks.plugins.DynmapHook.onUnvanish(DynmapHook.java:50) ~[?:?] at org.kitteh.vanish.hooks.HookManager.onUnvanish(HookManager.java:123) ~[?:?] at org.kitteh.vanish.VanishPlugin.hooksUnvanish(VanishPlugin.java:214) ~[?:?] at org.kitteh.vanish.VanishManager.toggleVanish(VanishManager.java:208) ~[?:?] at org.kitteh.vanish.VanishCommand.onCommand(VanishCommand.java:45) ~[?:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[Spigot.jar:git-Spigot-3af4605-ed8cef0]

commented
by: java.lang.NullPointerException at org.dynmap.bukkit.DynmapPlugin.assertPlayerInvisibility(DynmapPlugin.java:1503)  ~[?:?] at