Vault

Vault

7M Downloads

PermissionsBukkit: use lowercase player names (e.g. playerInGroup, possibly others)

asofold opened this issue ยท 2 comments

commented

playerInGroup on Vault side uses PermissionsPlugin.getPlayerInfo which uses "getNode("users/" + playerName)" which then looks up that path in the configuration, bluntly.

I think that PermissionsBukkit would internally use lower case everywhere (see the commands class), so vault should also use lower-case when using getPlayerInfo and possibly others !

This will lead to failures, when adding groups, then checking if they are there, using Vault.

playerAddGroup uses a command which means playername will be used lower cased inside of PermissionsBukkit

playerInGroup will result in a check for the given letter case of the players name due to getPlayerInfo not converting to lower case.

It seems best if Vault uses lower case in those places for PermisisonsBukkit.

commented

probably, I'll get it fixed thanks.

commented

fixed in build 171