Vault

Vault

7M Downloads

Issue with iConomy (8)'s new API.

RyanGarber opened this issue · 11 comments

commented

iConomy 8.4.5 has a new API, in which makes Vault-dependant plugins fail to load. You would need to remove either iConomy or MultiVerse. The API's implementation only changes the imports from com.iCo6 to com.iCo8 as well as have a new imported jarfile

( http://dev.rtainnovations.com/projects/iconomy/build-dl/8.5a/iconomy.jar )

commented

Forewarning: I've seen this pop up a few times.

The Vault team is going to ask for a PR with proof that iConomy 8 fixes the major bugs in iCo 6.

commented

as @turt2live said, and I've already stated. The iCo8 project has already once been removed from DBO for simply being a rename of iCo6. If you would like it to be supported it will need to show that it is actually fixing the issues in iCo6 and not just a continuation for the sake of naming. I will be closing this 'issue' as it seems to be going nowhere.

commented

You guys can't just add the new API? I mean many, many, many people are waiting for me to tell them that their plugins will work again.

commented

If iCo 8 doesn't fix any bugs... why should they?

commented

@rtainc - many many many people? sounds ambiguous and like you don't actually have people using your plugin. I already get a breakout of plugins that use Vault the majority of them use either iCo6, EssEco, or none at all. Since your plugin doesn't do anything to iCo6, why would people even upgrade?

commented

Clearly, not one to take constructive criticism well. Nothing of value was
lost.

On 22 November 2012 01:50, RTA Innovations [email protected] wrote:

No comment. I'm just done with you bitchy developers.


Reply to this email directly or view it on GitHubhttps://github.com//issues/303#issuecomment-10621267.

commented

It's not being bitchy.

It's actually worthless to support 2 things that do 100% EXACTLY the same thing.

There was no evidence of change, be it a new feature, a bug fix, or proof of activity. Because of this Sleaker has no cause to update his plugin.

commented

@Sleaker Oh and also, I'd fixed flat file, and many people have used it for about 3 months now with no problems. I think that's a huge upgrade that people love. That's why people upgrade. I don't push much to Github anymore, as the second developer isn't coding anymore (don't ask me, I don't know why).

commented

@rtainc - if that's truly the case, then feel free to make a Pull Request for a new Economy connector for iCo8.

Unfortunately.. I did a quick compare and the minidb files are 1-1 identical and haven't fixed the threading problem. So I'm not sure where you're getting the.. you fixed it already stuff from.

commented

People, as in inside testers, I'm still working on it.

commented

There's no point for a pull anymore, as I've rolled back the API.