Vault

Vault

7M Downloads

VAULT / PEX GROUP SETTING ISSUE - URGENT

JAG100 opened this issue · 9 comments

commented

I'm not a developer but I recent upgraded to the 1.7 version of Vault and ran into a serious problem and just discovered that Vault was the culprit.

I have some plugins that we rely on including a Jail plugin and a couple others that use Vault to change a user's RANK in our PERM file. We happen to use PEX so I don't know if this issue is larger than PEX or not. Prior to 1.7 version of Vault, when the plugins change a user's group (using bu4444 as example) Vault would change "vip" below to a new value.

bu4444:
group:
- vip

With the new version of Vault it looks something like the below where the original rank is not altered but instead a new world specific rank is added. This was wreaking all kinds of havoc and it took me a few hours to release it was the new version of Vault causing the issue. I downgraded Vault and it works fine.

bu4444:
group:
- vip
worlds:
world:
group:
- vaultputsrankhere

Please email me back at [email protected] if you need any further input. I do hope this issue can be fixed!

commented

This is not a Vault issue... this is your permissions plugin being inaccurate.

commented

Travis,

Not looking to debate. :-)

All I know is that the prior Vault release for 1.6.2 plays nice with
Pex and the latest version does not. I haven't changed anything on the
PEX side only upgraded to 1.7.2 version of Vault wherein the issue began....

Best,
Joseph

On 2/15/2014 11:36 AM, Travis Ralston wrote:

This is not a Vault issue... this is your permissions plugin being
inaccurate.


Reply to this email directly or view it on GitHub
#515 (comment).

commented

It's not a debate. Vault does nothing but proxy the information.

This is the fault of another plugin, be it your permissions plugin or the plugin implementing Vault support.

commented

I believe I isolated this issue correctly.

I have two unrelated plugins that both use Vault to hook into pex and
make group rank updates and both are having the same issue.

Something in Vault is different between 1.6.2 and 1.7 that is causing
the update of group to be interpreted as a world level group assignment
wherein previously the same code would simply change the group that the
user is assigned to without adding Worlds: World type of nesting wherein
the global group setting is completely bypassed.

I believe I described the situation above to demonstrate the issue.

I was able to fix it by rolling back to the prior version of Vault.

All I know is the latest version of Vault caused the issue as nothing
else has changed.

On 2/15/2014 11:54 AM, Travis Ralston wrote:

It's not a debate. Vault does nothing but proxy the information.

This is the fault of another plugin, be it your permissions plugin or
the plugin implementing Vault support.


Reply to this email directly or view it on GitHub
#515 (comment).

commented

I'll just let the Vault people deal with this from here on out...

I was just trying to explain that Vault is rarely at fault.

On Sat, Feb 15, 2014 at 1:00 PM, JAG100 [email protected] wrote:

I believe I isolated this issue correctly.

I have two unrelated plugins that both use Vault to hook into pex and
make group rank updates and both are having the same issue.

Something in Vault is different between 1.6.2 and 1.7 that is causing
the update of group to be interpreted as a world level group assignment
wherein previously the same code would simply change the group that the
user is assigned to without adding Worlds: World type of nesting wherein
the global group setting is completely bypassed.

I believe I described the situation above to demonstrate the issue.

I was able to fix it by rolling back to the prior version of Vault.

All I know is the latest version of Vault caused the issue as nothing
else has changed.

On 2/15/2014 11:54 AM, Travis Ralston wrote:

It's not a debate. Vault does nothing but proxy the information.

This is the fault of another plugin, be it your permissions plugin or
the plugin implementing Vault support.

Reply to this email directly or view it on GitHub
#515 (comment).

Reply to this email directly or view it on GitHubhttps://github.com//issues/515#issuecomment-35166148
.

Sincerely,
Travis R

(Turt2Live http://turt2live.com/)

commented

I hear you but I believe I properly isolated this situation and was just
being nice to report it.

On 2/15/2014 12:01 PM, Travis Ralston wrote:

I'll just let the Vault people deal with this from here on out...

I was just trying to explain that Vault is rarely at fault.

On Sat, Feb 15, 2014 at 1:00 PM, JAG100 [email protected] wrote:

I believe I isolated this issue correctly.

I have two unrelated plugins that both use Vault to hook into pex and
make group rank updates and both are having the same issue.

Something in Vault is different between 1.6.2 and 1.7 that is causing
the update of group to be interpreted as a world level group assignment
wherein previously the same code would simply change the group that the
user is assigned to without adding Worlds: World type of nesting wherein
the global group setting is completely bypassed.

I believe I described the situation above to demonstrate the issue.

I was able to fix it by rolling back to the prior version of Vault.

All I know is the latest version of Vault caused the issue as nothing
else has changed.

On 2/15/2014 11:54 AM, Travis Ralston wrote:

It's not a debate. Vault does nothing but proxy the information.

This is the fault of another plugin, be it your permissions plugin or
the plugin implementing Vault support.

Reply to this email directly or view it on GitHub
#515 (comment).

Reply to this email directly or view it on
GitHubhttps://github.com//issues/515#issuecomment-35166148
.

Sincerely,
Travis R

(Turt2Live http://turt2live.com/)


Reply to this email directly or view it on GitHub
#515 (comment).

commented

@JAG100 - there has been 1 changed to the PEX connector in the last 2 months and it was a minor world-fix on group addition/removal. https://github.com/MilkBowl/Vault/commits/master/src/net/milkbowl/vault/permission/plugins/Permission_PermissionsEx.java

If plugins don't properly supply a world, or supply null then groups are done in the global space. This is an issue with your rank plugins not Vault.

commented

So the three plugins that I happen to have that all use Vault and all
work properly in 1.6.2 version of Vault and all break in the 1.7.2
version of Vault as I described are all at fault? This minor world-fix
on group additional/removal has changed the status quo and breaks these
plugins. Why must all of these plugins be updated in order to work
properly?

On 2/15/2014 8:34 PM, Nick Minkler wrote:

@JAG100 https://github.com/JAG100 - there has been 1 changed to the
PEX connector in the last 2 months and it was a minor world-fix on
group addition/removal.
https://github.com/MilkBowl/Vault/commits/master/src/net/milkbowl/vault/permission/plugins/Permission_PermissionsEx.java

If plugins don't properly supply a world, or supply null then groups
are done in the global space. This is an issue with your rank plugins
not Vault.


Reply to this email directly or view it on GitHub
#515 (comment).

commented

They weren't handling ranks properly to begin with because of the bug they were unaffected. They will need to be fixed either way.