Vault

Vault

7M Downloads

Events again

nick4fake opened this issue ยท 12 comments

commented

Hello. I know, that adding events is someway impossible due to workflow of permission/economy plugin.
BUT!
Vault is public api for connecting them, so... why not just add this functionality to every connector/plugin? I mean, create public service which would trigger events once it received message from economy plugin. Of course, this would lead to improving every economy/permission plugin, but the Vault was written for such stuff.

I suggest:

  • adding events API
  • notify developers of third-party plugins about new API
  • ???
  • profit!
commented

maybe like now? :)
As usual - plugin connectors.

commented

Also, what if I make pull-request with my changes? Would you accept such functionality?

commented

Doesn't Bukkits permissions do something like this? And you can just have it so it connects to Bukkits perms?

commented

The main reason is economy, of course.

commented

Oh I see - interesting, how would Vault know that there is a plugin there to use the economy?

commented

Could you explain, why?

commented

Why we can not alter essentials behaviour?

commented

Because I'm not the essentials developer and they don't need to hook Vault for dealing with any of their own economy stuff?

commented

I understand that. But if we do not cooperate now, this situation would continue forever.

commented

So again, I suggest creating draft API-document for economy events. I think we could persuade Essentials developer to integrate it.

commented

The major issue is Events wont work with Essentials Eco due to how it handles it's own economy internally, anything that happens inside of essentials and with any of the other plugins that directly connect to Essentials rather than through Vault, it simply wont work.

If you take a look at: http://mcstats.org/plugin/Vault you'll see that EssentialsEco makes up for about 60% of the install base. So 60% of users will have partial/broken functionality from this.

commented

@nick4fake - That would not work. You can't have some plugins hooking directly to an Economy, and others into Vault and have consistency. Thanks for your enthusiasm, but this is not something that can be resolved in a universal API connector, it's something that needs to happen at the economy implementation only.