Recommendation Bukkit scope to provided instead of default compile
yannicklamprecht opened this issue · 7 comments
Bukkit shouldn't be shaded into the jar, as a custom artifact set is provided (https://github.com/MilkBowl/Vault/blob/master/pom.xml#L446-L451). If you package vault it shouldn't contain bukkit.
The shade goal is working as expected:
[INFO] --- maven-shade-plugin:3.1.0:shade (default) @ Vault ---
[INFO] Excluding org.bukkit:bukkit:jar:1.13.1-R0.1-SNAPSHOT from the shaded jar.
[INFO] Excluding commons-lang:commons-lang:jar:2.6 from the shaded jar.
[INFO] Excluding com.googlecode.json-simple:json-simple:jar:1.1.1 from the shaded jar.
[INFO] Excluding junit:junit:jar:4.10 from the shaded jar.
[INFO] Excluding org.hamcrest:hamcrest-core:jar:1.1 from the shaded jar.
[INFO] Excluding com.google.guava:guava:jar:21.0 from the shaded jar.
[INFO] Excluding com.google.code.gson:gson:jar:2.8.0 from the shaded jar.
[INFO] Excluding org.yaml:snakeyaml:jar:1.21 from the shaded jar.
[INFO] Including net.milkbowl.vault:VaultAPI:jar:1.7 in the shaded jar.
[INFO] Including org.bstats:bstats-bukkit:jar:1.5 in the shaded jar.
[INFO] Excluding com.greatmancode:craftconomy3:jar:3.2.2-SNAPSHOT from the shaded jar.
[INFO] Excluding com.greatmancode:tools:jar:1.3-SNAPSHOT from the shaded jar.
[INFO] Excluding org.xerial:sqlite-jdbc:jar:3.7.15-M1 from the shaded jar.
[INFO] Excluding org.slf4j:slf4j-api:jar:1.7.12 from the shaded jar.
[INFO] Excluding com.zaxxer:HikariCP-java6:jar:2.3.7 from the shaded jar.
[INFO] Excluding org.javassist:javassist:jar:3.18.2-GA from the shaded jar.
[INFO] Excluding com.h2database:h2:jar:1.4.187 from the shaded jar.
[INFO] Excluding org.projectlombok:lombok:jar:1.12.6 from the shaded jar.
[INFO] Replacing original artifact with shaded artifact.
Can you add some steps to reproduce or give some more proof?
https://www.spigotmc.org/threads/player-spigot-does-not-exist.406974/#post-3621773
The value in the pom xml provided in the Vault jar could be the problem.
<dependency> <groupId>org.bukkit</groupId> <artifactId>bukkit</artifactId> <version>${bukkitVersion}</version> <type>jar</type> </dependency>
Then you're just wrong here. This is the repository for the vault implementation, you're searching for the API. You can find the corresponding repo here: https://github.com/MilkBowl/VaultAPI :D
I would be very happy if you could transfer this issues to the VaultAPI project.
I'm sadly not a maintainer. @Sleaker will have to do this for you.
github doesn't have a 'transfer issue' command like that. also I'm not sure what you're reporting here.
@Sleaker In fact it has, "brand" new :D You can move issues inside an organization easy using the bottom at the bottom:
His problem is described here: https://www.spigotmc.org/threads/player-spigot-does-not-exist.406974/#post-3621773
It seems like he would have a problem with the exposed bukkit api.