VoidSpawn

VoidSpawn

133k Downloads

vs.enable permission checked continuously

SlimeDog opened this issue ยท 7 comments

commented

Spigot 1.13 latest
VoidSpawn 1.17.0

While moving up or down through water (or "bobbing" on the surface), the vs.enable permission is checked every tick. The ocean floor is at Y=46 in the test scenario, nowhere near Y<0. This seems unnecessary.

commented

Thanks for reporting this. I will change this for the next patch. Will move it after the detector check.

commented

This is true for water of any kind: ocean, river, pond.

commented

If 100 players decided to do this, it would have a negative impact on TPS.

commented

Thanks.

commented

vs.enable also seems to be checked continuously when the player is not in water, just moving around on any surface. Every 2 ticks or so.

commented

It is not clear why the permissions need to be checked at all until a player passes into the void.

commented

Ya, that is an error on my part. Happened when I did a small refactor.