Wilderness-Tp

Wilderness-Tp

36.7k Downloads

IllegalArgumentException when world's center Z value exceeds the defined ranges in the config

I-Knight-I opened this issue ยท 23 comments

commented

https://www.spigotmc.org/threads/wilderness-tp.145440/page-29#post-3696748

I linked my log a few messages below that one. I couldn't see anything that might cause problems. Unfortunately, this is still an issue so opening this.

In the meantime - since it seems you've been inactive or busy - I'm going to try edit the source myself and see if I can narrow it down in order to fix it. If I find the problem, I'll update the issue here and explain what it was.

Wild version 2.15-a6aebd3
Paper #103
MC 1.15.2

commented

since it seems you've been inactive or busy

No, it's just that I don't look for bugs on spigotmc. That's where I answer questions when I'm usually on my phone. By the time I'm at an IDE I'm looking solely at github for the most part.

commented

Ah gotcha, my bad. It's just because you hadn't responded to the discussion is all. I should've opened an issue here earlier to be honest, so that's my fault.

commented

Gonna need to see your config.

commented

They're all Gists, not downloads. Added the other two just to be certain and rule out everything.

Config.yml
Messages.yml
Portals.yml

Want me to download the latest build with that commit up there? And try again?

commented

Yea, using 71a8cfd will help get a specific line.

commented

Sorry, can you do me a favour and send through a built .jar? Whenever I build it, my plugin manager throws errors and can't seem to identify it. It keeps complaining about the plugin.yml but I've checked repeatedly and it's all fine.

Your class names are hilarious btw haha

commented

Cheers. Here's the full stacktrace:

https://mcpaste.io/432ad8f749c26584

commented

Ok better, can you enable debug mode and paste output?

commented

That is debug mode and that is the output...

commented

Oh ok. I saw debug messages for printing the world border but doesn't seem that has been fired here. What's the border of world? e.g. what are the outputs of the border get and center commands.

commented

Added my own quick debug lines to see if it'd do anything.
wc, who and way is below:

[19:14:12 WARN]: player = CraftPlayer{name=BKnight_}
[19:14:12 WARN]: worldconfig = net.poweredbyhate.wildtp.WorldConfig@48a8f091
[19:14:12 WARN]: direction = null

Worldborder get is 60000000. Centre is 0.0, 500001
WorldBorder is 60K x 60K.
X = -30,000 to 30,000
Z = 470,000 to 530,000

Lemme know if you need anything else.
EDIT: Sorry, updated the figures for the centre.

commented

found a typo in his worldborder logic for vanilla worldborders. Gonna also add debugging info to that. Either way though I'm gonna guess the typo will fix this (it had to do with the Z value which yours is very large compared to the X value).

commented

for vanilla worldborders.

We don't use a vanilla one though, we use the plugin WorldBorder?

commented

Uhm actually it affects both vanilla and the plugin. If you're using the worldborder plugin then /worldborder get and etc. I don't think would've worked... also, you should've had debug messages printing out said border so that's interesting... oh I see, he only checks it if movingBorder is enabled, otherwise he does the check once beforehand so time to go hunting again.

That being said the minXY includes both X and Z so your config doesn't match your world border. Hmm.

commented

I was trying to respond to this and mysteriously somehow I can't access or ping any of GitHub.com's servers from just my home internet so that's wonderful, and I have no idea why it's happening. Anyways...

commented

idk why I accepted this PR, I thought the code we wrote was semi obfuscated but this is just big oof

commented

idk why I accepted this PR, I thought the code we wrote was semi obfuscated but this is just big oof

Not sure what you mean. The code is definitely not obfuscated and thank fuck it's not. Please, please do not obfuscate your code.

Regardless, if you think you've fixed it, I appreciate it.

commented
commented

Ok, yea it's also called when the WorldConfig is generated (which I guess is during onEnable) so yea that should fix it.

Yea takes a while to load that enormous diff lol.

commented

Okay - has Github broken? hahahahaha

commented

EDIT2: Config.yml had MaxXY = 30,000 rather than 530,000. Dude, you really gotta change that fucking config option name lol. minX, maxZ or MinXZ, MaxXZ. Teleporting is fixed now.

commented

Have a word with @LaxWasHere