WorldEdit for Bukkit

WorldEdit for Bukkit

21M Downloads

Add permissions to commands that do not have them

mcmuffindk opened this issue ยท 1 comments

commented

Versions

WorldEdit version: Bukkit-Official(7.2.2+fc3c499)
Platform version: Paper version git-Paper-520 (MC: 1.16.5)

Describe the bug

Some WE commands either misses permissions or ignores them when doing tab completion and/or executing them wrongfully

To Reproduce

  1. Create a fresh install of Paper
  2. Install WE and LuckPerms
  3. Set up permissions to deny all WE commands
  4. Try //br in various forms, both correct and incorrect

Expected behavior

It is expected that when you have denied all WE permissions, the commands should not show up in the tab completion list also the command help should not be returned when the user is not permitted to use the command

commented

I guess this can be the official tracking issue for adding permissions to these commands, since we never made one.

Notes:
This is technically not a bug, but a feature request. Some commands such as /brush none do not have permissions associated with them, so //br should show up.

We have a few options:
(A) Add permissions to these commands.
- Pros: works like everything else
- Cons: these commands will gain permissions after 10 years, breaking a lot of expected behavior. They will need to be specially granted to players if other plugins hook into the worldedit tool system, or e.g. re-use the selection wand. Not a great experience.

(B) Add "default-on" permissions to these commands.
- Pros: better migration flow, no breaking behavior
- Cons: a lot more work to implement, won't work on all platforms and may need a config override.