WorldEdit for Bukkit

WorldEdit for Bukkit

21M Downloads

Locate .archive-unpack in /tmp/ (or equivalent on non-Linux)

SlimeDog opened this issue ยท 12 comments

commented

The Problem

WE unzips the languages files in ./plugins/WorldEdit/.archive-unpack/ on server start-up. That's 1.5MB of data, the vast majority of which are irrelevant, since our server uses only en-US.

A Solution

Unzip the archive into something like /tmp/WE-archive-unpack or equivalent temporary storage on non-Linux systems.

Alternatives

At present, plugins/WorldEdit/.archive-unpack/ is listed for exclusion from (tar) backups on our servers. But since the directory is hidden, everyone doesn't know about it, so their backups are 1.5MB larger than they need to be.

Anything Else?

No response

commented

See #1576 for the PR that changed this behavior.

commented

We used to do this, but it turned out to be an issue on many computers. I'd be open to a PR that re-adds it behind a config option though.

commented

We don't know what ones are unnecessary, it's based on client language.

commented

Alternative: When WorldEdit finishes creating .finish-unpack and strings.json, delete the unnecessary language archives.

commented

It would be standard to create the languages that are actually used in plugins/WorldEdit/lang/ (or similar), instead of in a hidden subdirectory.

But OK. I'll remove them my own self.

commented

It was hidden with the express purpose of being skipped by archival tools. I feel it is more your backup setup that is incorrect here.

commented

A new language file could easily be created as-needed. Many, if not most, players on any particular server employ a single language (I respect that will not be the case for large servers).

commented

^^^
" plugins/WorldEdit/.archive-unpack/ is listed for exclusion from (tar) backups on our servers. "

But it still takes 1.5MB on disk. I know disk is cheap, but waste is waste.

commented

It's not waste though, just because you're not wanting to use languages other than English does not mean your players will not.

Plus, putting it in tmp does not change this

commented

BTW, Linux tar archives . files along with everything else not specifically excluded.

commented

Fine. You have your reasons. I have mine. Thanks for discussion.

commented

That's not what this code is doing. You are welcome to make a PR as stated earlier, but this discussion is becoming unproductive.