SimpleAlias

SimpleAlias

Bukkit Plugins
59.7k Downloads

Wrong variable assignment

cbronak opened this issue ยท 0 comments

commented

In Alias.java, there is a wrong variable assignment:

usageCheckMaxParams = config.getInt(AliasSetting.USAGE_CHECK_MAX_PARAMS.getPath());

should be used instead of

usageCheckMinParams = config.getInt(AliasSetting.USAGE_CHECK_MAX_PARAMS.getPath());

and regarding the plausibility checks, (if (delayDuration < 1) etc.) it would be helpful not to validate these values if the respective check is not enabled, so a setting like

Cooldown:
  Enabled: false
  Duration: 0

doesn't get rejected. ( if (delayEnabled && delayDuration < 1) )