Yamipa

Yamipa

Bukkit Plugins
3.7k Downloads

Yamipia causing crashes on latest protocollib

LuluxClient opened this issue · 6 comments

commented

My server crash this morning and after checking the logs it's related to Yamipia and Protocollib: error: https://pastebin.com/E1uhab7H

Crash report: https://pastebin.com/NvMZE2s4

commented

Hello @LuluxClient,

Appears to be related to line 67:

yamipa/src/main/java/io/josemmo/bukkit/plugin/utils/InteractWithEntityListener.java

Lines 62 to 70 in 0abaec8

@Override
public final void onPacketReceiving(@NotNull PacketEvent event) {
Player player = event.getPlayer();
// Discard out-of-range packets
List<Block> lastTwoTargetBlocks = player.getLastTwoTargetBlocks(null, MAX_BLOCK_DISTANCE);
if (lastTwoTargetBlocks.size() != 2) return;
Block targetBlock = lastTwoTargetBlocks.get(1);
if (!targetBlock.getType().isSolid()) return;

Will investigate further. In the meantime, what ProtocolLib version + build number are you using?

commented
commented

Hello @LuluxClient,

I cannot reproduce this issue on Pufferfish 1.19.2 (build 36). The server you're using (Pufferfish+) requires a license that I don't have, so I cannot test it there.

Why did the crash occur? Did you perform any action in particular?

According to the documentation, Player#getLastTwoTargetBlocks() shoudn't throw any exception (which is what's happening). I can surround this call with a try/catch block and call it a day, but I'd like to know if this is a Pufferfish issue or a PaperMC/SpigotMC issue.

commented

Hi, @LuluxClient!

Any updates on this? Were you able to re-trigger the exception?

commented
commented

Ok, might have been some weird error from Pufferfish+.

For the moment, I'm closing this issue. If it happens again, feel free to post the new stack trace here (alongside the server version/details) and I'll reopen it.