Yamipa

Images are unloading, when switching chunks.
Why are not all images visible at the same time?

yamipa.mp4

Yamipa 1.2.7 on Paper 1.19.2.

@ampersandhd

What's the view distance for your server/world?

Server Properties are Set to 8 Chunks and we are using viewdistancetweaks for a Dynamic Farther view. The Blocks behind the images are rendered, too. The problem is also not happening everywhere on our Server. I am 2 chunks away at that Video example.

viewdistancetweaks must be lowering the view distance for plugins calling world.getViewDistance(), because Yamipa makes use of that method to determine which images should be loaded when nearby a player:

yamipa/src/main/java/io/josemmo/bukkit/plugin/renderer/WorldAreaId.java

Lines 59 to 71 in 1fd4319

    
               /** 
        
                * Get nearby world area IDs in view distance (plus this one) 
        
                * @return List of neighbors 
        
                */ 
        
               public @NotNull WorldAreaId[] getNeighborhood() { 
        
                   // Get value from cache (if available) 
        
                   if (neighborhood != null) { 
        
                       return neighborhood; 
        
                   } 
        
                   // Calculate neighborhood size from world's view distance 
        
                   int size = (USE_WORLD_VIEW_DISTANCE ? world.getViewDistance() : Bukkit.getServer().getViewDistance()) / 4;

I'll try to investigate it further.

https://pastebin.com/i2uqNWmK

Still cannot reproduce the bug :(

I do, however, now have an idea as to what the cause of the bug might be, which is that changing the WorldAreaId size at runtime might yield unexpected results.

I'm going to prepare a patch and let you know when it's ready so you can try it.

I Suppose, you Need More than one sind Player to reproduce it. So that chunks are loading and unloading within the plugin. Awaiting your fix.

@ampersandhd

@ampersandhd you can now try v1.2.8-SNAPSHOT-b2.

I cannot reproduce this issue using the latest version of ViewDistanceTweaks (v1.5.4).
What is your "config.yml" file for that plugin?

We are at Viewdistancetweaks 1.5.3 - we Test, If updating fixes the issue

Issue still persists with ViewDistanceTweaks (v1.5.4).
Here's the config:

https://pastebin.com/W7g9kAjz

Any ideas for a fix or reproduction?

@ampersandhd

@ampersandhd, the configuration file you shared is not valid:

[19:16:42 INFO]: [ViewDistanceTweaks] Enabling ViewDistanceTweaks v1.5.4
[19:16:42 ERROR]: [ViewDistanceTweaks] Exception while loading configuration:
[19:16:42 WARN]: java.lang.IllegalStateException: Could not find version while initialising config.yml.
[19:16:42 WARN]:        at ViewDistanceTweaks-1.5.4.jar//com.froobworld.viewdistancetweaks.lib.nabconfiguration.NabConfiguration.init(NabConfiguration.java:44)
[19:16:42 WARN]:        at ViewDistanceTweaks-1.5.4.jar//com.froobworld.viewdistancetweaks.lib.nabconfiguration.NabConfiguration.load(NabConfiguration.java:30)
[19:16:42 WARN]:        at ViewDistanceTweaks-1.5.4.jar//com.froobworld.viewdistancetweaks.ViewDistanceTweaks.onEnable(ViewDistanceTweaks.java:30)
[19:16:42 WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264)
[19:16:42 WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:371)
[19:16:42 WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:544)
[19:16:42 WARN]:        at org.bukkit.craftbukkit.v1_19_R2.CraftServer.enablePlugin(CraftServer.java:578)
[19:16:42 WARN]:        at org.bukkit.craftbukkit.v1_19_R2.CraftServer.enablePlugins(CraftServer.java:492)
[19:16:42 WARN]:        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:635)
[19:16:42 WARN]:        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:434)
[19:16:42 WARN]:        at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:301)
[19:16:42 WARN]:        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1101)
[19:16:42 WARN]:        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:316)
[19:16:42 WARN]:        at java.base/java.lang.Thread.run(Thread.java:833)
[19:16:42 WARN]: Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "java.util.Map.get(Object)" is null
[19:16:42 WARN]:        at ViewDistanceTweaks-1.5.4.jar//com.froobworld.viewdistancetweaks.lib.nabconfiguration.NabConfiguration.init(NabConfiguration.java:42)
[19:16:42 WARN]:        ... 13 more
[19:16:42 INFO]: [ViewDistanceTweaks] Disabling ViewDistanceTweaks v1.5.4

If I'm not able to reproduce this issue, I'll have to close it.

I am going to Paste the Original File Here. Could you maybe view the issue live on our server, Too?

This snapshot seems to fix the issue. Great Job!

	/**
	* Get nearby world area IDs in view distance (plus this one)
	* @return List of neighbors
	*/
	public @NotNull WorldAreaId[] getNeighborhood() {
	// Get value from cache (if available)
	if (neighborhood != null) {
	return neighborhood;
	}

	// Calculate neighborhood size from world's view distance
	int size = (USE_WORLD_VIEW_DISTANCE ? world.getViewDistance() : Bukkit.getServer().getViewDistance()) / 4;

Share to