Datapack Utils

Datapack Utils

2k Downloads

Missing blocks in "non-solid" and "fluids" tags

krazy-j opened this issue ยท 1 comments

commented

Using the latest release, 2.3.3.

While looking at tags, I noticed some things were missing.

#du:non-solid only has redstone_torch, and #du:emit_light only has torch and soul_torch. Neither includes any wall torches. Maybe add #du:torches, containing all 6 torch blocks, which could then be included in #du:non-solid, #du:emit_light, #mechanization:drill/empty, and any other tags that apply.

#du:non-solid doesn't contain fluids. I don't know if this is intended, but I thought I'd point it out just in case.

#du:place_block_through contains air variants plus water and lava when it could simply use #du:air and #du:fluids.

#du:fluids lacks bubble_column. I assume this is just a small oversight, as it's easy to miss.

#du:tall_flowers seems unnecessary, as it is identical to #minecraft:tall_flowers

#du:beds seems unnecessary, as it is identical to #minecraft:beds

Finally, in my opinion, the #du:water-loggable tag name seems odd, as the Minecraft blockstate is waterlogged, not water-logged. #du:waterloggable seems simpler and more intuitive.

See also: Missing blocks in drill tags (Mechanization)

Summary

  • #du:non-solid lacks torch, wall_torch, soul_torch, soul_wall_torch, and redstone_wall_torch.
  • #du:non-solid lacks fluids. Maybe add #du:fluids or #du:place_block_through.
  • #du:emit_light lacks wall_torch, soul_wall_torch, redstone_torch, and redstone_wall_torch.
  • Maybe add #du:torches (containing torch, wall_torch, soul_torch, soul_wall_torch, redstone_torch, and redstone_wall_torch).
  • #du:place_block_through could use #du:air and #du:fluids.
  • #du:fluids lacks bubble_column.
  • #du:tall_flowers is a duplicate of #minecraft:tall_flowers.
  • #du:beds is a duplicate of #minecraft:beds.
  • Rename #du:water-loggable to #du:waterloggable?
commented

Implemented these in 3.4.0