Infinite Music Discs

Infinite Music Discs

66 Downloads

Fails to convert to ogg even with ffmpeg/multiprocessing processing all files

BEANIEBOI417 opened this issue ยท 20 comments

commented

I put in any music file and even if its already ogg it says cant covert file to ogg. I dont know what im doing wrong

commented

Which version of the app are you using? If it's older than v1.6.1, try upgrading to the latest version. If that doesn't fix it, try turning on the setting that says "convert tracks to .ogg one at a time". If that doesn't fix it, I don't know what the problem could be and I would need more information from you to figure it out (like what kind of files are you using, how many, did you download them from somewhere, etc).

commented

Having same problem with 1.6.1. Converting one at a time option doesn't seem to help.
My tracks are in .ogg format converted from .flac using ffmpeg.

commented

@sacu85 I just tested your files with v1.6.1 and v1.5 and they worked for me... not sure why they would behave differently for you vs me. I tried a couple of settings combinations and was able to generate a pack in all cases. When you tried to generate a pack with these files, were they both named "test"? Because you can't have 2 discs with the exact same name, you'll have to change one of them so they're unique.

@Mantas22XYT That is interesting and good to know. If it's not too much trouble, can you send me your failing files? My working theory is people are downloading ogg files with malformed headers from online audio converter websites, so when the app tries to parse the track length (datapack needs to know this) it fails and throws an error. But if you converted a track to ogg with ffmpeg on your own computer and it still failed then maybe that theory is not true...

commented

I have a set of 19 songs in ogg and mp3 formats that behave in the way I described before. These files have different names. I just picked two random files, renamed to test.mp3, test.ogg and attached to my previous post.

All my files give convertion errors in v1.6.1. Only ogg files work in v1.5 - I guess this version keeps ogg files as they are and does not perform any convertion. My observations are the same on my 2 computers, with Windows 10 and 11.

Maybe it's a matter of some additional libraries or convertion tools which are required. I didn't download anything except from the binaries from the GitHub website (https://github.com/TeamTernate/infinite-music-discs/releases).

commented

I attach two test files in the zip archive. test.ogg and test.mp3 don't work in 1.6.1 - no matter which options I choose I get convertion error. Suprisingly, test.ogg works in 1.5 but this version also fails incase of test.mp3.

test.zip

commented

Does every single song that you put into the app not work? Or do you have a lot of songs that work fine, and 19 that don't work? Just want to make sure I understand what you said correctly. This is sounding like a problem with ffmpeg/pyffmpeg.

You shouldn't need to download anything other than the app for it to work. Just to test, I deleted my ffmpeg binary and let pyffmpeg re-extract it, but the app still worked fine. I'll try deleting Python from another computer and run the app there to make sure you don't need Python installed.

Btw your guess is correct, in v1.5 and earlier the app just copies ogg files without processing them (this was changed in v1.6 to fix a different bug).

commented

In v1.6.1 none of my songs work, even when I put them individually into the app. In v1.5 was able to create a working datapack and resource pack after manually converting all my songs to ogg format.

commented

i am having the same problem, i downloaded an mp3 from a youtube converter and it doesn't work

commented

@bradytheinventor One of the files I'm trying to convert is here: song.zip

commented

OS may have something to do with it. I wrote my previous comment testing on my windows 10 PC. I then tried the same files on my windows 11 laptop, and it generated my packs without issue.

commented

I am also experiencing this issue. I downloaded .ogg files from this website and was told it failed to convert. I then downloaded them as .mp3 files, but those also failed to convert to ogg. I then tried a few different websites downloading various mp3's and none of them worked either. I then decided to try version 1.6, but the result was the exact same. However, version 1.5 worked perfectly. So that eliminates the idea that the files are corrupt somehow.

commented

I tried my two laptops - one with Windows 10 and another one with Windows 11. In both of them v1.6.1 failed to convert mp3 and ogg files. Version 1.5 works, but only with ogg files . So I think that the problem is related to something else than Windows version.

commented

I ran the app in a Windows 11 VM without Python installed and it worked fine, so neither of those are the problem. I might try rolling back the pyffmpeg version to see if that helps.

commented

Is there any way to get detailed error logs? If so, I can give you logs from my two computers.

commented

im having the same issue, it always says "Failed to covert some tracks to '.ogg' format

has anyone found a solution?

commented

i am in a windows 10 pc and basically i am trying to get the calamity musics into minecraft but am having the same problem my version is 1.6.1 too

commented

or maybe idk but i give the files to you guys and yall just make the pack for me cuz idk how on earth its failing to tutn ogg files to ogg

commented

anyone still here?

commented

Try using version 1.5. It works when you have already prepared ogg files.

commented

This bug is so persistent and I still haven't been able to figure out the source... It's so strange because the exact files that don't work for other people work just fine for me, on any computer I test on! For now I just released v1.6.2 which turns off the parallel processing by default (with a setting to turn it back on) and copies ogg files straight through without processing them (with a setting to process ogg files if that was helpful for you). In v1.6.2, the app behaves like it did in v1.5 by default, but still gives you the advanced features if you want to enable them. I highly recommend the parallel processing if it works for you, it saves a lot of time.

In the next release I want to rework the error messages so they're displayed per-file. That should help debugging. I also want to make the generator skip over files with errors, so if a few files are not working it can still generate a pack with all of the other files.