Potion Effect Fog does not render behind partially transparent blocks
hibiii opened this issue ยท 3 comments
Blocks such as stained glass, respective panes, water (and the water part of waterlogged blocks), as well as in item form. Effect Fog also does not render when the camera is underwater, or behind the player tag when they're sneaking (this is a vanilla bug). This bug happens with the blindness or darkness effects.
Environment:
- Minecraft 1.19 with Quilt Loader 0.17.0, Sodium 0.4.2+build.16 and Iris 1.2.5
- Adoptium Java 17.0.1 on Linux amd64 on mesa drivers.
- MakeUp UltraFast version 8.6
I take note of the issues with the fog, of this and the other report you send, but I anticipate that it will take me a while to review the problem.
Okay. I have checked exactly what you mean.
The inconsistencies with the drawing behind the translucent objects that you mention are a consequence of the limitations of the pipeline that Optifine presents, and design decisions of the shader.
Fixing the root of this particular issue involves changing the way the shader works, to the detriment of speed, and I honestly don't want to do that, because that's the purpose of the shader before anything else: to be fast.
I'll try to see what can be done without affecting performance, and without disturbing how the shader works too much, little by little.
The other's non-circular fog problem can be fixed without changing anything in the overall structure, although it's also something that involves a little more calculation, so I'll revisit its impact later.
I want to clarify that I can't do magic, and the speed of MakeUp is the result of a bag of tricks and shortcuts, like these, that save calculations. I don't want to do anything against this if it affects too much.