
Not working right (Appearance as well as function)
NealSavage opened this issue · 14 comments
Glad to hear it's working again!
The food calculations are correct, since it just averages the hunger and saturation values across all ingredients, so dropping a comparatively low value ingredient like a melon slice into a higher value stew like bread & chicken will lower the values of the end result.
I've considered a few alternatives, but this is the one that seemed easiest to understand and implement, but if you've got another idea, please let me hear it!
Huh. Thank you for bringing that to my attention. I'll go take a look at it and get back to you.
While I'm doing that, what's your mod list? Just to make sure it's not a compatibility issue somewhere.
EDIT: Seems like at some point after my development for 1.21.4's version, the "tag" folder was changed back to "tags" as in previous versions. Uploading the (hopefully) fixed version to Modrinth in a moment.
Glad to hear it's working again! The food calculations are correct, since it just averages the hunger and saturation values across all ingredients, so dropping a comparatively low value ingredient like a melon slice into a higher value stew like bread & chicken will lower the values of the end result.
I've considered a few alternatives, but this is the one that seemed easiest to understand and implement, but if you've got another idea, please let me hear it!
Would something as something as adding up the total of the food value (say the 3 from the bread, the 3 from the cooked chicken, and the 1 from the melon slice, for a total of 7, then taking 60% of that, making it be 4.2 base food satisfaction from that particular combo before the bonus levels? And if only one ingredient is in the stew, just leave it at that one ingredient's food satisfaction, so just cooked chicken would be 3. Is that a decent idea?
Or what other ideas have you had?
Huh. Thank you for bringing that to my attention. I'll go take a look at it and get back to you.
While I'm doing that, what's your mod list? Just to make sure it's not a compatibility issue somewhere.EDIT: Seems like at some point after my development for 1.21.4's version, the "tag" folder was changed back to "tags" as in previous versions. Uploading the (hopefully) fixed version to Modrinth in a moment.
Updated to your new version and it's working again! Thanks! This is one of my all time favorite mods and I use it in all my playthroughs haha
Huh. Thank you for bringing that to my attention. I'll go take a look at it and get back to you.
While I'm doing that, what's your mod list? Just to make sure it's not a compatibility issue somewhere.EDIT: Seems like at some point after my development for 1.21.4's version, the "tag" folder was changed back to "tags" as in previous versions. Uploading the (hopefully) fixed version to Modrinth in a moment.
Only thing is that the amount of hunger that its portions help with seem a bit wonky.
Bread and chicken stew is worth 3 food each portion, when bread and chicken each as an individual ingredient are worth 3.
And then bread, chicken, and melons is worth only 2, which is even less than the other stew.
Not sure if it's determining its food value correctly.
Nothing yet, but I do have a plan for a potential silly new feature for crock pot. If you'd like to help me test it (it's gonna be real dumb/fun), add me on Discord. Just
nosrick
there as well.
Oh gawsh, I am so sorry for the late response! I work hard 10 hour shifts 4 days a week and then often relax hard the other 3 days or travel for one of the days and relax extra hard the other 2 days hahaha.
It says you aren't accepting friend requests and that you have to add me :( What should we do?
I spoke a little too quickly about the saturation values, as I've not actually changed that code in a while and forgot I handle hunger differently from saturation. The hunger values work by adding the base hunger value of each different type of ingredient together, then averaging across the quantity of different ingredients. So with the bread (5), cooked chicken (6) and melon slice (2) you end up with a hunger value of 4 after rounding, and that directly affects the saturation values due to the way Minecraft itself uses a ratio for saturation, rather than a direct value. Because of that, setting a direct saturation value of 4.2 for this particular concoction would require figuring out the ratio needed to bring the 4 up to 4.2, and I'm unsure if that calculation is worth making for the difference it'd make. Does that make sense?
The way saturation works for the crock pot is fairly simple, and by default, can range from a ratio of 0.7 (plain) to 1.2 (hearty) depending on how many bonus levels you've got in the pot.
I've also just realised Minecraft displays 1 hunger as half an icon, and 1 saturation as a whole icon, to add to the confusion.
Edit to add:
The original crock pot algorithm was quite different, and took into account both the quantity and quality of each and every ingredient, which made recalculating costly, especially on larger servers with 20+ people using 3+ crock pots who cram 64 portions of food into each.
What you've proposed is a bit like a more generous version of how the hunger values work at the moment, anyway. But I could definitely see about making it a little more generous, or giving players more options to tinker with the internal algorithm.
Updated to your new version and it's working again! Thanks! This is one of my all time favorite mods and I use it in all my playthroughs haha
I somehow only just saw this absolutely wonderful message, and it's completely made my day. I'm so glad my silly little mod is your favourite! Thank you so much for the kind words, Neal.
I spoke a little too quickly about the saturation values, as I've not actually changed that code in a while and forgot I handle hunger differently from saturation. The hunger values work by adding the base hunger value of each different type of ingredient together, then averaging across the quantity of different ingredients. So with the bread (5), cooked chicken (6) and melon slice (2) you end up with a hunger value of 4 after rounding, and that directly affects the saturation values due to the way Minecraft itself uses a ratio for saturation, rather than a direct value. Because of that, setting a direct saturation value of 4.2 for this particular concoction would require figuring out the ratio needed to bring the 4 up to 4.2, and I'm unsure if that calculation is worth making for the difference it'd make. Does that make sense?
The way saturation works for the crock pot is fairly simple, and by default, can range from a ratio of 0.7 (plain) to 1.2 (hearty) depending on how many bonus levels you've got in the pot.
I've also just realised Minecraft displays 1 hunger as half an icon, and 1 saturation as a whole icon, to add to the confusion.
Edit to add: The original crock pot algorithm was quite different, and took into account both the quantity and quality of each and every ingredient, which made recalculating costly, especially on larger servers with 20+ people using 3+ crock pots who cram 64 portions of food into each.
What you've proposed is a bit like a more generous version of how the hunger values work at the moment, anyway. But I could definitely see about making it a little more generous, or giving players more options to tinker with the internal algorithm.
Ahh I see! Makes sense! Yeah, some sort of settings ability could be good!
Updated to your new version and it's working again! Thanks! This is one of my all time favorite mods and I use it in all my playthroughs haha
I somehow only just saw this absolutely wonderful message, and it's completely made my day. I'm so glad my silly little mod is your favourite! Thank you so much for the kind words, Neal.
Haha, you're welcome! :)
What other mods do you make? I'd be super happy to help with anything possible!
Nothing yet, but I do have a plan for a potential silly new feature for crock pot. If you'd like to help me test it (it's gonna be real dumb/fun), add me on Discord. Just nosrick
there as well.
No worries at all! Life happens, I'm in no rush right now.
I must have stopped accepting friend requests from strangers at some point. I seem to recall a rash of friend request scams a little while back and that's probably why. Lemme change it back, and you can try again.