Groovyscript compatibility
Wizzerinus opened this issue ยท 4 comments
Is your feature request related to a problem? Please describe.
Groovyscript is a sort of new scripting tool for modpacks similar to Crafttweaker. It'd be nice to be able to add/change/remove rituals, transmutations and such through it. (I would be interested mostly in a 2.0-alpha version of it, but afaik the CT integration is done in the addon that is not supported on 2.0 :(
Usually integrations for various mods are added into the Groovyscript's upstream (see [https://github.com/CleanroomMC/GroovyScript/tree/master/src/main/java/com/cleanroommc/groovyscript/compat/mods](this github link)), but this seems like a bad idea in this case since AC's internals may change between 1.9 and 2.0 (I do not know how much they changed between versions), leaving either the one or the other group of players unable to use the mods together, even if they don't use the integration.
Describe the solution you'd like
Groovyscript compat either in the mod or an addon
Describe alternatives you've considered
If deemed useless in the AC's code base I can make a mod that does just that (see also: the issue about configuration since they're closely related).
2.0 is not backwards compatible with 1.0, so that's the first thing to note. This would either be something to implement natively in GroovyScript or to include when rewriting AbyssalCraft Integrations to work with the 2.0 API.
GroovyScript could actually use jar shadowing to support both the 1.0 API and the 2.0 one, where 1.0 support could probably be done with just making a copy of the CT integration and translate that to the correct syntax.
I'm probably going to make a compat as a companion mod for now, and maybe merge into either GS or AC/ACI later on :)
Quickly drafted up an implementation in an addon here (also applicable for Shinoow/AbyssalCraft#520 ) if someone else wants to have this kind of thing :)