AbyssalCraft

AbyssalCraft

20M Downloads

[1.10.2-1.9.3.10] Vanilla beacons cause Coralium plague.

JaSpr opened this issue ยท 20 comments

commented

We have repeatedly tested and verified that vanilla beacons cause coralium plague, along with their standard buffs. The only solution anybody on our server has been able to find is to remove the beacon entirely, thus removing the buff as well.

MC: 1.10.2
AC: 1.10.2-1.9.3.10
Forge: 12.18.3.2239
ModPack: All the Mods 1, versions 1.9 - 2.4

commented

That shouldn't have any effect on it at all (since that makes it possible to use blocks made from ingots of my materials as beacon bases), not to mention I used gold blocks in my test world. Still unable to get the beacon to spread the potion effect, but I can see it in the secondary power section before picking anything from the primary power section.

commented

I was unable to trigger it, but apparently it shows up (for some reason) before picking the initial buff (after doing so, it's replaced with an upgraded version of the buff).

commented

Players tended to notice it later (not initially upon selecting). I have been asked about three times over the past month why their bases had coralium plague. I asked if they placed a beacon recently, they said yes, and i told them it was probably coming from the beacon. Upon removing the beacons, all cases went away.

commented

Could this have something to do with IngotBlock#isBeaconBase always returning true??

commented

Here's an example of a beacon emitted Coralium Plague II http://i.imgur.com/Y0leA41.png.

The beacon might need to have the full size base with access to the second tier of effects. Also, it's the speed icon on the second tier that shows "Coralium Plague II" in the tooltip.

commented

That's exactly what it looks like in my workspace, but I still can't make it emit the potion effect.

EDIT: I installed ATM 1 (v 2.52), set up a beacon, it didn't emit it.

commented

ARG

commented

I can confirm this exact problem is happening on my server too, turning off beacons stops the plague

MC: 1.10.2
AbyssalCraft-1.10.2-1.9.3.10
Forge: 12.18.3.2254

commented

I think it's a server problem

commented

I'm unable to reproduce this on a dev server, so either it's a mod present in both cases doing something on servers or plugin (provided a server plugin framework is present in both cases) triggering this. Alternatively, if I can get some instructions on how to reproduce this, maybe there's something I can do on my end to circumvent it.

commented

It happend instantly after a player went to The End, they died (falling into the void), on respawn at there home everyone on the server within radius of a beacon got the plague. Not sure if that helps but its all info

commented

We don't use plugins, but do have this problem.

commented

We do use Sponge on our server... could that have something to do with it?

commented

Since the bug seems to occur without Sponge being present, it shouldn't be a factor.

commented

Rogonad is it possible that it's a potion ID conflict with Soul Fray from Blood Magic.

commented

Best bug report I've seen on github @LemADEC

commented

Using AbyssalCraft-1.10.2-1.9.4-pre-2.jar, issue is reproduced with:

  • lowest tier vanilla beacon (just 9 diamond blocks below)
  • never selecting a potion effect in the beacon
  • SSP and SMP
  • spongeforge-1.10.2-2281-5.2.0-BETA-2300

The issue doesn't appear initially when placing the beacon, something else is needed to trigger it.
On first occurrence, someone went through a portal while the another remained in the area. Breaking the beacon removed the effect.
On second occurrence, the server was restarted.
On third occurrence, I've fueled with a diamond and no effect selected.

When issue is present, the Plague effect will:

  • renew every 4 seconds from 11 seconds (7 to 10 displayed),
  • applies within 20 blocks radius of the bugged vanilla beacon.
    => this is consistent with Vanilla beacon behavior.

When activating the beacon (selecting Jump effect and adding a diamond), issue is no longer reproduced as the Plague effect properly goes away.

commented

After a bit of digging at various parts of the vanilla code, I believe I've found the source of why the Potion shows up in the Beacon Gui. Vanilla never registers a Potion with the ID 0, which happens to be the ID that's assigned to Coralium Plague when registered (I haven't tested, but the same thing should happen with any other mod adding it's own Potions). The Beacon itself doesn't permit the Potion to be applied, but all of it's logic defaults to 0 when no Potion to emit has been selected. What I suspect happens on Sponge's end would be that their stuff bypasses the vanilla check for the Potions it allows the beacon to apply, therefore allowing the plague to be spread (due to the lack of a "this isn't allowed" check).

commented

Is there an expected fix for this?