AbyssalCraft

AbyssalCraft

20M Downloads

Issue - Abyssalmobs Not Affected by OpenModularTurrets Turrets (Currently Tested with Lasers)

P3rf3ctXZer0 opened this issue ยท 5 comments

commented

OpenModularTurretsTeam/OpenModularTurrets#408

I am not going to do the layout extactly since this is more of an interaction rather than bug and since I don't know which is at fault but I feel both modders need to see this.
@Shinoow
@Keridos

Affected versions ("latest" is NOT a version):

  • Minecraft: 1.12.2
  • Forge:1.12.2 - 14.23.2.2632
  • AbyssalCraft: AbyssalCraft-1.12.2-1.9.4.4.jar
  • OpenModularTurrets: openmodularturrets-1.12.2-3.0.0-236.jar
  • OMLib: omlib-1.12.2-3.0.0-138.jar

Please leave this open until we figure out the cause because this is the first time I have ever encountered a bug like this.

commented

Hi, I am the dev of OpenModularTurrets. @Shinoow, could you either implement this: OpenModularTurretsTeam/OpenModularTurrets#373

or take a look at this: https://github.com/Lycanite/LycanitesMobs/issues/125

It would be helpful if you implemented either one of these, preferabily the second one, because it is much cleaner and does not require you to add OMT as dependency for your mod. OMT will not add custom support for each mod that adds creatures to minecraft, because simply put, there is too many of them.

/edit: this is the correct link to the abyssalmods example: https://github.com/Lycanite/LycanitesMobs/blob/Minecraft-1.7.10/java/lycanite/lycanitesmobs/api/entity/EntityCreatureBase.java#L2175

commented

@Keridos thank you for taking the time to inform @Shinoow he is a great modder as well and I love his mod.

commented

Judging by that issue (and code example), I shouldn't need to do anything (as all of my hostile mobs extend EntityMob, which in turn implements IMob). Putting IMob on passive mobs wouldn't really make much sense, considering they aren't monsters.

commented

Which mobs were not affected? Neutral or aggressive ones?

!possibleTarget.isDead && (possibleTarget.isCreatureType(EnumCreatureType.MONSTER, false)

@Shinoow maybe you do not have this implemented?

commented

Aggressive ones @Keridos