AcademyCraft

AcademyCraft

1M Downloads

Use singleton explicitly for non-reusable skills

WeAthFoLD opened this issue ยท 0 comments

commented

It doesn't look like a good practice to set singleton instance like this:

public SkillXXX() {
    ...
    instance = this;
}

It might (implicitly) encourage others to create and subclass the skill, which is not intended.