AcademyCraft

AcademyCraft

1M Downloads

[Idea] Command to add blocks to magnetic list

Xemnes-Keyethkateth opened this issue ยท 4 comments

commented

As mentioned on discord I think it would be great if there was a command to add blocks to the list of magnetic blocks.

The easiest way I can see it for players is to add a command that works similarly to how project e's command to add an EMC value to an item.
A command like /ac AddMetal or /ac AddWeekMetal could be used to add the block you are holding or if hand is empty the block you are looking at to the config list the use another command like /ac ReloadMetal to reload the config and update all the new blocks that where added.

Adding blocks to the config isn't always friendly to the end user as some mods use NBT or metadata that can make adding the blocks to the config difficult and needing to restart the game every time you update the config to check if it is working can also be slow if you are crafting a mod pack with a lot of mods.

(I'm not looking for this to be added to the 1.7.10 version of the mod as there was some confusion around that on the discord)

commented

Sounds like a good idea, but it requires to manipulate the config file programmatically, and that will introduce many problems (e.g. comments and formatting lost). Reloading the config at run-time seems more viable to me.

commented

Would it be possible to split the config and have them all in a folder so that they can be accessed separately and then adding blocks would not need to edit the main config file so there would be no loss of comments or formatting.

I am mostly looking at this from an end user and mod pack creators point of view, it can get very hard to add everything in one by one in a config file when you can have 100+ mods installed.

Thank you for your time and consideration.

commented

I am still in favor of editing manually and ad-hoc reloading approach more. If we separate the config into multiple files, there can be a lot things that can be separated out (e.g. entities that can be applied to vec reflection), and we need to add extra config & command for every one of these for consistency. This adds an extra layer of complexity IMO.

Ad-hoc reloading is way more generic. You edit the config file, use /ac reload_config (or whatever), and everything reloads. We can also add more error checking for the file to improve the experience.

commented

Opened a feature issue in #760