Curios Compat Layer for Accessories

Curios Compat Layer for Accessories

719k Downloads

[Issue] High TPS Usage Accessories due to Others's Costly use NBTPredicate Call

LilithASMP opened this issue · 2 comments

commented

Hello there, I'm reporting here to warn of a certain bug/incompatibility, I looked for many solutions but found nothing, the only solution I have was to remove accessories to fix this TPS problem.

Here the spark profiler ; https://spark.lucko.me/fvE1kcTnnr

What's the problem ;

  • There is a huge TPS issue ( 20-30% perf ), the trigger seems to be the server that checks every tick all the entities of something, and if I go any lower ( in the profiler ) I find accessories at 5% performance consumption

I tried to remove the mods and it fixed this TPS problem by 20% ( here the spark profiler with a lot of optimisation and without accessories ; https://spark.lucko.me/vJPMW6Usue )

I've also tried to ;

Accessories + full inventory with artifacts ; 20%
check without artifacts/relics mods ; 8%
without anything in the inventory ; 3%
Without accessories but with artifacts/relics ; 9%
Without the artifacts/relics/accessories ; 5%

Maybe it is an issue on our side but i'll report it anyway ( maybe someone else have the same issues )

Anyway, thanks for all the work and happy easter day ♥

commented

Yes this is caused by some one using a command that requires the constant encoding of Entity Data to find a specific entity with data and this is causing quite a bit of slow down but nothing much can be directly done here besides finding the root cause and convince said developer to use a more light weight predicate for finding entities if possible.

commented

I will keep this issue open for tracking possible workaround, but other mods like Trinkets and Curios may also have this issue. I believe some remedies could be done to improve performance yet such would only occur within the future.