
Bug: [1.20.1] Curios Compatibility Layer appears to use an outdated Curios API version, causing incompatibility with some Curios mods.
templeofshadow opened this issue ยท 2 comments
What Feature Types Apply to This Bug?
API
Feature Type
Compatibility Layer API
What Type of Bug Is This?
Compatibility
Minecraft Version
1.20.1
Mod Loader
Forge
Mod Loader API Version
47.4.0
The Accessories Version
1.0.0 beta 46
What Compatibility layer are you using?
Curios
The Compatibility Version
7.4.0 beta 18
Is This Bug a Conflict With Another Mod?
Samurai Dynasty (example; could be any mod which uses the class mentioned below)
Client Log
No response
Crash Report (if applicable)
No response
Steps to Reproduce
Always happens on installation and launch of Minecraft with Accessories, Curios Compat Layer, and Samurai Dynasty (as an example).
What You Expect To Happen
Minecraft launching to menu.
What Actually Happened
Forge Modloader error: Samurai Dynasty cannot find class definition of curios.api.client.ICurioRenderer.HumanoidRender.
Additional Details
This appears to be a fairly straightforward error; for API parity between curios and accessories via the compat layer, the layer needs to have an accessories-api-based implementation for api.client.ICurioRenderer.HumanoidRender.
Here is the API class definition in the main Curios mod: https://github.com/TheIllusiveC4/Curios/blob/a91da6ba2396f6ed9042c8a47a471ca5efc97da8/src/main/java/top/theillusivec4/curios/api/client/ICurioRenderer.java#L279C2-L279C78
This is the file in the compat layer mod, missing the class: https://github.com/Dragon-Seeker/CuriosCompatLayer/blob/6f7ea9e880c80105f8e16728eeb81854ef50fb3b/src/main/java/top/theillusivec4/curios/api/client/ICurioRenderer.java
Here is an example of how Samurai Dynasty uses this API class: https://github.com/VeroxUniverse/SamuraiDynasty-neoforge/blob/61398b39af28ea1856aa26e77240b6eab480386d/src/main/java/net/veroxuniverse/samurai_dynasty/curios/layers/KitsuneMaskRenderer.java#L21
I apologize for any errors in report formatting or tag attribution.
If you need more information, please let me know.
Please Read and Confirm The Following
- I have confirmed this bug is on the most recently supported version of Minecraft.
- I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
- I have confirmed this bug is unique and has not been reported already.
- If playing on a modpack, I have reported this bug to their issue tracker already.
Sorry to say but I am not shocked as I knew such could have been possible when watching the chats about trying to add a fix
and overall find that with the changes are not going to be updated for 1.20.1 as such is no longer supported due to the code differences. This problem dose not occur within 1.21.1 which is the current supported version.