Accurate Maps

Accurate Maps

16.8k Downloads

Incompatible with carpet 'hoppercounter'

MeeniMc opened this issue ยท 7 comments

commented

For some reason, when this mod is loaded, the carpet rule 'hopperCounter' doesn't work anymore.

commented

Let's be a bit more helpful with replication steps

MC 1.19.3
Accurate Maps 1.1-BETA+1.19 (self compiled from PR #6)
Carpet 1.4.93

  1. Load a world
  2. place a wool block, place a hopper pointing inside the wool block
  3. type /carpet hoppercounter true
  4. place items in the hopper
  5. number of items doesn't decrease, counter doesn't count
commented

Is this a problem only with 1.19.3, or does this happen on every version of the mod?

commented

I didn't try with prior versions yet.

commented

I can replicate with 1.19.2 (using the gradlew runclient and adding carpet 1.4.84 by hand to the run/mods directory).

BTW the maven pulled Architectury (for REI runtime dependency) is bust.

commented

Maybe this

worldView.getBiome(pos).getKey().ifPresent(blockBiome -> cir.setReturnValue(AccurateMapColor.Companion.getAccurate(originalColor, blockBiome, blockState, pos)));

causes a problem w.r.t to https://github.com/gnembon/fabric-carpet/blob/23ed35a3983d1571ecdca03cc157b0d52b189071/src/main/java/carpet/mixins/HopperBlockEntity_counterMixin.java#L43

commented

Either way it would be nice if this could get pushed since I've been waiting a while to use this mod.

commented

Presumably resolved by patch on Carpet side. Will reopen if still present in 1.19.4/20 when mod updates.