Actually Additions

Actually Additions

66M Downloads

Feeder should feed only animals it cares about

Ricket opened this issue ยท 1 comments

commented

https://github.com/Ellpeck/ActuallyAdditions/blob/master/src/main/java/de/ellpeck/actuallyadditions/mod/tile/TileEntityFeeder.java#L69

The feeder should filter the list of animals down to only those where isBreedingItem(this.slots.getStackInSlot(0)), then choose a random animal. This would allow you to place a feeder in a pen of mixed animals, and it would be much more efficient at feeding those animals.

Also, I'm pretty sure it would be cheaper to do the StackUtil.isValid(this.slots.getStackInSlot(0)) check prior to doing the AABB operation.

commented

Thanks for fixing, I had a few code comments regarding horses which I added to the commit.