Actually Additions

Actually Additions

66M Downloads

Tweak? isRepairable() vs getIsRepairable() in Item Repairer

Aedda opened this issue ยท 1 comments

commented

I've recently run into a small problem where a mod with armor items returned getIsRepairable() as false but didn't also override isRepairable() to return the same, the author was unaware of there being two similar methods. As a result placing their armor in the Item Repairer caused a crash...

java.lang.ArithmeticException: / by zero
	at de.ellpeck.actuallyadditions.mod.tile.TileEntityItemRepairer.getItemDamageToScale(TileEntityItemRepairer.java:129)

Would it be a lot of trouble and if not would you consider checking for both methods prior to performing a repair? It may prevent a bug report or two in the future. :)

commented

I didn't know there was two variants either.