Actually Additions

Actually Additions

66M Downloads

[Issue] ESD causing severe tick issues

MysticAura opened this issue ยท 11 comments

commented

MC: 1.10.2
Forge: 2185
Mod: ActuallyAdditions-1.10.2-r94

Tps had gotten severly low on the sub-server so I ran some profiling. Narrowed the bulk of the issue to TileEntityInputter. After removing AA from the pack the tps went from 13 back to 20. Of course I'd prefer not to lose this mod if it can be avoided.

Profiler log

There was nothing about it at all in the fml/latest and of course no crash report.

commented

Well now we have an issue to work out.
Thanks for investigating :)

commented

The thing that's weird about this is the fact that while the ESD already has items in it, it shouldn't be scanning the inventory it pulls from (the large crate in this case) for any items, which would be causing the most lag here.
I can't reproduce this either, but I guess I'll try adding a cooldown to the ESD to try to reduce the load it creates. That'd be a little better gameplay wise anyways. :v

commented

The latest commit should've fixed this.
Thanks for the help :)

commented

I hope the latest release fixes your problem. The thing with something as big as the Large Crates is that obviously it searches the entire crate for items if there aren't any in there, which is going to be happening with any item transport mechanic, so there is only so much I can do. But I hope the changes I made fix the issue :)

commented

What was the setup that caused the lag..?

commented

I also don't know what you mean by "New inputter class", because this class is like 2 years old O_o

commented

Just misspoke due to googling too much on the issue, and saw when you said it was a new class. The rest stands though ๐Ÿ˜Š

Not sure which setup is causing the lag. It's on TLove's sub server so many people are using the laser system, and not all have their bases marked. I really miss opis.

commented

My question does too, and without an answer to it I can't do anything about this issue.
What was the setup this Tile (the ESD) was involved in that caused this lag?

commented

I could give you a link to the pack involved and the world folder if it would help.

commented

It would help most if you were able to pin down the issue.
I have never heard of any problem with the ESD causing tick lag ever before, and I can't really think of why it would be causing any either, so this is on you :/

commented

After spending the last 3 hours in level dat and using custom mods to track down the coordinates of the offending ESD's on the server, the one causing the biggest issue was pulling from a large crate and pushing into your dropper. It was holding one item in inventory waiting for space. It was part of someones disenchanting setup. The instant I broke the block the tps went back to decent levels.
I wasn't trying to insult you, or make up problems. I reported thinking it's something you'd want to know about.