Don't clear out chest inventory when upgrading storage crates because Minecraft is stupid
Tarod7 opened this issue ยท 1 comments
maxanier (the Vampirism dev) asked if I could reopen this over here.
TeamLapen/Vampirism#162
He was asking about this in the closed thread. #748
"Is there a specific reason you are clearing out the old chest's/TileEntity's inventory?
The problem is: The BlockPlace event is thrown after the item placed the block. If the event is canceled by any mod (e.g. Vampirism) Minecraft restores the Block and the TileEntity. But since you cleared the inventory of the old tile before it was stored (during setBockState of the new chest), it's inventory is empty and all items are lost."
Versions
Minecraft: 1.10.2
Forge: 12.18.3.2281
Vampirism: 1.1.0 beta.2
Actually additions r105
Issue Description
Vampirism bat mode makes storage crate upgrades destroy crate contents without upgrading
Reproduce Steps
place a small storage crate and put some junk in.
change into bat form
use a small to medium upgrade on the small crate by shift clicking it on it.
crate doesn't upgrade and the contents are destroyed.