Actually Additions

Actually Additions

66M Downloads

[Minecraft 1.12.1] Very abuseable Duplication Glitch

andr9528 opened this issue ยท 3 comments

commented

Having a almost full (one slot remaining) medium storage crate, i were noticing things began stacking above 64, item that exist in one slot and when more are put in to fil the last slot, is also added to the existing ones in the crate while also filling up the remaining open slot.

I noticed this while pulling out a lot of pulverized ores from them, through my applied Llamagistics system, i should also have gotten around 54 pulverized iridium, but ended up with 423 pulverized iridium. i'm unsure if the crate was full while pulling those out, so it might not even be completely related to them being full, but something funky is happening with insertion and extraction of them.
While pulling out the pulverized dusts other were continually duplicating, so where i should have gotten a half small crate i got over a hole small crate of pulverized dust.

2017-09-15_15 57 27

Notice the Cinnabar.

2017-09-15_16 23 20

This next one is just from me taking out and putting back in the cinnabar (after a couple of tries, as it didn't do it immediately)

2017-09-15_16 25 04

I'm unsure if this only is a problem with the medium one or if all 3 has the issues, but it is a big one, that needs to be fixed rather quickly, hope this helps.

commented

It's some issue with priority and the crates, but its not on our end.

commented

they have priority 0, with nothing from the AE pulling it out automaticly

commented

https://github.com/Ellpeck/ActuallyAdditions/blob/master/src/main/java/de/ellpeck/actuallyadditions/mod/util/ItemStackHandlerCustom.java#L107

You return your internal copy of the ItemStack when it's a simulation. Check against the Forge implementations that copy it before returning.