Ad Astra

Ad Astra

22M Downloads

[1.18.2] Crash when using Shaders while on other planets.

ConqAra opened this issue · 6 comments

commented

(Tested on Mars) When traveling to, and landing on, mars you will crash if you have shaders (tested with BSL Shaders) on.

Crashlog starting with the Error and list of mods in the pack just in case it's not just iris.

commented

It's extremely difficult for mod devs to diagnose issues caused by optimization and shader mods, such as sodium + iris. I can't tell if this is an Ad Astra issue or Iris issue, but nevertheless, I'd recommend reporting it on Iris's GitHub. You can disable shaders on planets for now, until it's fixed.

commented

Does Ad Astra make a mixin for ItemStack that could cause ItemStack::getItem to return null (e.g. by setting the value of the stack to null without updating empty)? if it does, that would cause this issue.

commented

There's no ItemStack mixin and as far as I am aware, I don't set any stacks to null. Only thing I've seen that might be causing issues is this

commented

Another shader issue #26 was recently fixed on the latest 1.19.2 version and I wonder if it correlates with this at all. Can you try on the latest version and see if it still crashes?

commented

This is an issue in Iris that we’ve fixed in 1.4.1, releasing soon.

(It did not check for an invalid item.)

commented

Great to hear that it's fixed