Extreme local lag when felling a tree
kazum1kun opened this issue · 10 comments
Describe the bug
It seems like something's wrong when I try to fell a tree using Mana and Artifice's fell tree spell. Whenever I do that there will be
immense lags (1 FPS) for everyone in the neighborhood where the tree fell. The lags can persist up to 20 seconds. Also the server reports errors like the following
[13:09:56] [Server thread/WARN] [APTweaks:EntityManager/]: Unknown entity name for entity EntitySpellFX['Spell FX Entity'/3235290, l='ServerLevel[world]', x=962.50, y=74.50, z=1514.50] (entity.mana-and-artifice.spell_fx) in minecraft:overworld. Please report this issue under https://github.com/MarkusBordihn/BOs-Adaptive-Performance-Tweaks/issues/!
To Reproduce
Steps to reproduce the behavior:
- Use Fell Tree (from Mana and Artifice) on any tree
- Lag
Expected behavior
Tree fells normally, no lag
Debugging
See above error message
Is the issue happening in combination with other mods? (If yes, please provide a full list)
This mod is part of a modpack (see https://www.curseforge.com/minecraft/modpacks/astral-engineering/relations/dependencies)
Additional context
Server is running fine, no TPS drop or anything. Just client side suffering apparently.
Game version 1.16.5, Mod version 2.0.0
Thanks for your assistance!
Thanks a lot for the report, it has mostly nothing to do with the Unknown entity name because all of these entities are automatically excluded from any optimization by this mod. Furthermore the mod is only performing server side optimization.
But I will try to reproduce the issue with the corresponding mods to see if I could isolate the issue.
Thanks for your response, that makes sense. I have followed up with the modpack author and will let you know if there's any update.
I tried to reproduce the issue and build some "fell tree spell" but was unfortunately not able to reproduce the issue.
If you could still reproduce the issue you can try the following:
- Use
/aptweak debug trueto enable the debug mode - Fell the tree and some seconds during the log
- Use
/aptweak debug falseto disable the debug mode
Your log should now include some additional lines which kinds of entities, items etc. has joined and left the world.
Share this log with me and I will check if I see anything strange here.
Thanks, I got a ton of stuff not sure if they are all relevant (mostly seems to be a tons of blocked spawn in Nether), but here they are
https://pastebin.com/raw/Jp2TiKst
Let me know if you need anything further :)
Unrelated notes, is there a way to disable server load change notifications? Currently I'm seeing avg 1 notif per second because the server load keeps changing between VERY_LOW and LOW. Thanks!
I just released a fix to ignore the spell entity from any optimization and the logs.
But I think I found the issue in your case, I checked the client log and found the following entries, after breaking a large amount of logs:
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
[17:15:02] [Sound engine/WARN]: Maximum sound pool size 247 reached
[17:15:02] [main/WARN]: Failed to create new sound handle
Could you please check if you get the same kind of warning in your client log.
If yes, this should be reported to the mod owner so that they are limiting / combining the playSound events for breaking the tree.
Unfortunately the code of Mana and Artifice is not publicly available, so I'm not really able to check this further.
Thanks for the log, found the relevant part:
[25Mar2022 13:50:51.467] [Server thread/DEBUG] [APTweaks:EntityManager/]: Entity mana-and-artifice:residual_magic (EntityResidualMagic['entity.mana-and-artifice.residual_magic'/5941504, l='ServerLevel[world]', x=509.50, y=69.00, z=11.50]) joined minecraft:the_nether.
[25Mar2022 13:50:51.467] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.467] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.468] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.468] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.468] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.468] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.468] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.469] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.470] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.471] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.471] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.471] [Server thread/DEBUG] [APTweaks:ItemEntityManager/]: Item minecraft:warped_stem Warped Stem joined minecraft:the_nether.
[25Mar2022 13:50:51.471] [Server thread/WARN] [APTweaks:EntityManager/]: Unknown entity name for entity EntitySpellFX['Spell FX Entity'/5941527, l='ServerLevel[world]', x=508.50, y=68.50, z=10.50] (entity.mana-and-artifice.spell_fx) in minecraft:the_nether. Please report this issue under https://github.com/MarkusBordihn/BOs-Adaptive-Performance-Tweaks/issues/!
[25Mar2022 13:50:51.471] [Server thread/WARN] [APTweaks:EntityManager/]: Unknown entity name for entity EntitySpellFX['Spell FX Entity'/5941528, l='ServerLevel[world]', x=508.50, y=68.50, z=10.50] (entity.mana-and-artifice.spell_fx) in minecraft:the_nether. Please report this issue under https://github.com/MarkusBordihn/BOs-Adaptive-Performance-Tweaks/issues/!
This means if you break the tree with the spell, the minecraft:warped_stem will be spawned as individual blocks (in the same tick), which is not optimal but ok.
But according this log, APTweaks is not optimizing or clustering them which could only happen in two cases:
- Item clustering feature is disabled
- The items are spawned in a strange way so that they are not recognized as items in the same radius.
Could you please share your AptTweaks CommonConfig to see whats options are enabled / disabled.
Inside the common config you can disable the logging of the server load with "logServerLoad = false".
Anyways according the debug log it doesn't look like an issue from APTweaks itself, I will exclude the magic entities with the next update to see if this has any effect.
The config file will help me to understand why the item optimization is not working in your case, which could be a hint to the underlying issue.
Thanks.
Thanks for the config. In the config the item clustering is disabled, so it's expected that they are not combined.
You can try to re-enable it with "optimizeItems" (and restart the server) to see if this help to reduce the lag, but there is maybe a reason why this is disabled in this mod pack.
Thank you so much for your assistance! The following is the current config on my server
https://pastebin.com/raw/anbLtcBN
I checked debug.log on my end but did not find the sound pool error there. But I will deploy the latest patch and see if that helps.
Thanks again for your time!