Additional Additions | Fabric

Additional Additions | Fabric

5M Downloads

Some recipes are missing

calloatti opened this issue ยท 11 comments

commented

Test scenario:

Minecraft: 1.18.2
Loader: FABRIC 0.14.8

Mods

APIs/LIBs

Missing recipes:

Trident Shard
Depth Meter
Gold Ring

Checking the jar file, confirmed that those are missing in data\additionaladditions\recipes

commented

Should have read the wiki first. Only the Depth Meter recipe is missing, since the other 2 are drops/trade items.

commented

Send your config file

commented

This is it: https://paste.ee/p/FKtDl

The config is the default one, to be sure I deleted everything in the config folder and restarted MC, still missing the depth meter recipe.

commented

Just a wild guess here since I know nothing about Java, but maybe this line:

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER)) toRemove.add(identifier); }

Should be:

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER, "enabled")) toRemove.add(identifier); }

In

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER)) toRemove.add(identifier); }

commented

Thanks a lot for reporting that!

commented

Sure! It's all played on Minecraft 1.19 with Fabric Loader 0.14.8
AA version is 5.0.1. Here are the latest.log and the config in txt format:

latest.log
additional-additions-config.txt

commented

Suposedly it is fixed, but I can't craft the depth meter yet...

commented

@kxkxrxtx Can you send your config & additional additions version & minecraft version & latest log?

commented

Please update ADAD to 5.0.2, it was fixed in 5.0.2. @kxkxrxtx

commented

When is this going to be backported to the 1.18.2 branch? It's still an issue unfortunately.

commented

Just a wild guess here since I know nothing about Java, but maybe this line:

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER)) toRemove.add(identifier); }

Should be:

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER, "enabled")) toRemove.add(identifier); }

In

case "depth_meter" -> { if (!Config.getBool(ConfigValues.DEPTH_METER)) toRemove.add(identifier); }

This actually does fix the problem as I just tested it, all I had to do was add the, "enabled" part and build the mod and it fixed the problem